* [PATCH] generic/603: don't run on XFS v4 filesystems
@ 2020-07-29 2:51 Darrick J. Wong
2020-07-29 4:53 ` Zorro Lang
0 siblings, 1 reply; 2+ messages in thread
From: Darrick J. Wong @ 2020-07-29 2:51 UTC (permalink / raw)
To: Eryu Guan; +Cc: fstests
From: Darrick J. Wong <darrick.wong@oracle.com>
XFS filesystems require V5 format to support all three quota types at
the same time, so skip the test if we're testing XFS older than that.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
tests/generic/603 | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tests/generic/603 b/tests/generic/603
index 54deaf13..fc3df6e5 100755
--- a/tests/generic/603
+++ b/tests/generic/603
@@ -149,6 +149,10 @@ test_grace()
_supported_fs generic
_supported_os Linux
_require_scratch
+# xfs requires v5 format to support all three quota types at the same time
+if [ "$FSTYP" = "xfs" ]; then
+ _require_scratch_xfs_crc
+fi
_require_setquota_project
_require_quota
_require_user
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] generic/603: don't run on XFS v4 filesystems
2020-07-29 2:51 [PATCH] generic/603: don't run on XFS v4 filesystems Darrick J. Wong
@ 2020-07-29 4:53 ` Zorro Lang
0 siblings, 0 replies; 2+ messages in thread
From: Zorro Lang @ 2020-07-29 4:53 UTC (permalink / raw)
To: fstests
On Tue, Jul 28, 2020 at 07:51:41PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> XFS filesystems require V5 format to support all three quota types at
> the same time, so skip the test if we're testing XFS older than that.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
Thanks for fixing it!
Reviewed-by: Zorro Lang <zlang@redhat.com>
> tests/generic/603 | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tests/generic/603 b/tests/generic/603
> index 54deaf13..fc3df6e5 100755
> --- a/tests/generic/603
> +++ b/tests/generic/603
> @@ -149,6 +149,10 @@ test_grace()
> _supported_fs generic
> _supported_os Linux
> _require_scratch
> +# xfs requires v5 format to support all three quota types at the same time
> +if [ "$FSTYP" = "xfs" ]; then
> + _require_scratch_xfs_crc
> +fi
> _require_setquota_project
> _require_quota
> _require_user
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-29 4:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-29 2:51 [PATCH] generic/603: don't run on XFS v4 filesystems Darrick J. Wong
2020-07-29 4:53 ` Zorro Lang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).