FSTests Archive on lore.kernel.org
 help / color / Atom feed
From: Zorro Lang <zlang@redhat.com>
To: fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH] generic/603: don't run on XFS v4 filesystems
Date: Wed, 29 Jul 2020 12:53:48 +0800
Message-ID: <20200729045348.GH2937@dhcp-12-102.nay.redhat.com> (raw)
In-Reply-To: <20200729025141.GW7600@magnolia>

On Tue, Jul 28, 2020 at 07:51:41PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> XFS filesystems require V5 format to support all three quota types at
> the same time, so skip the test if we're testing XFS older than that.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---

Thanks for fixing it!
Reviewed-by: Zorro Lang <zlang@redhat.com>

>  tests/generic/603 |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tests/generic/603 b/tests/generic/603
> index 54deaf13..fc3df6e5 100755
> --- a/tests/generic/603
> +++ b/tests/generic/603
> @@ -149,6 +149,10 @@ test_grace()
>  _supported_fs generic
>  _supported_os Linux
>  _require_scratch
> +# xfs requires v5 format to support all three quota types at the same time
> +if [ "$FSTYP" = "xfs" ]; then
> +	_require_scratch_xfs_crc
> +fi
>  _require_setquota_project
>  _require_quota
>  _require_user
> 


      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-29  2:51 Darrick J. Wong
2020-07-29  4:53 ` Zorro Lang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200729045348.GH2937@dhcp-12-102.nay.redhat.com \
    --to=zlang@redhat.com \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

FSTests Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/fstests/0 fstests/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 fstests fstests/ https://lore.kernel.org/fstests \
		fstests@vger.kernel.org
	public-inbox-index fstests

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.fstests


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git