FSTests Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] xfs/010,030: filter AG header CRC error warnings
@ 2020-07-29  2:51 Darrick J. Wong
  2020-07-29  4:49 ` Zorro Lang
  0 siblings, 1 reply; 6+ messages in thread
From: Darrick J. Wong @ 2020-07-29  2:51 UTC (permalink / raw)
  To: Eryu Guan; +Cc: fstests

From: Darrick J. Wong <darrick.wong@oracle.com>

Filter out the new AG header CRC verification warnings in xfs_repair
since these tests were built before that existed.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 tests/xfs/010 |    7 ++++++-
 tests/xfs/030 |    2 ++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/tests/xfs/010 b/tests/xfs/010
index e220a651..b65dd3ba 100755
--- a/tests/xfs/010
+++ b/tests/xfs/010
@@ -113,7 +113,12 @@ _check_scratch_fs
 # nuke the finobt root, repair will have to regenerate from the inobt
 _corrupt_finobt_root $SCRATCH_DEV
 
-_scratch_xfs_repair 2>&1 | _filter_repair_lostblocks
+filter_finobt_repair() {
+	sed -e '/^agi has bad CRC/d' | \
+		_filter_repair_lostblocks
+}
+
+_scratch_xfs_repair 2>&1 | filter_finobt_repair
 
 status=0
 exit
diff --git a/tests/xfs/030 b/tests/xfs/030
index efdb6a18..ebe4c92a 100755
--- a/tests/xfs/030
+++ b/tests/xfs/030
@@ -42,6 +42,8 @@ _check_ag()
 			    -e '/^bad agbno AGBNO for finobt/d' \
 			    -e '/^bad agbno AGBNO for rmapbt/d' \
 			    -e '/^bad agbno AGBNO for refcntbt/d' \
+			    -e '/^agf has bad CRC/d' \
+			    -e '/^agi has bad CRC/d' \
 			    -e '/^Missing reverse-mapping record.*/d' \
 			    -e '/^unknown block state, ag AGNO, block.*/d'
 	done

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] xfs/010,030: filter AG header CRC error warnings
  2020-07-29  2:51 [PATCH] xfs/010,030: filter AG header CRC error warnings Darrick J. Wong
@ 2020-07-29  4:49 ` Zorro Lang
  2020-07-29 14:50   ` Darrick J. Wong
  0 siblings, 1 reply; 6+ messages in thread
From: Zorro Lang @ 2020-07-29  4:49 UTC (permalink / raw)
  To: Darrick J. Wong; +Cc: Eryu Guan, fstests

On Tue, Jul 28, 2020 at 07:51:19PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Filter out the new AG header CRC verification warnings in xfs_repair
> since these tests were built before that existed.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---

Hi Darrick,

I still hit an error[1] on xfs/030 after merge your patch.

Thanks,
Zorro

# diff -u ./tests/xfs/030.out ./results//xfs/030.out.bad                                                          
--- /root/git/xfstests-dev/tests/xfs/030.out    2020-03-12 11:22:50.063148796 +0800
+++ /root/git/xfstests-dev/results//xfs/030.out.bad     2020-07-29 12:33:08.485428533 +0800
@@ -105,6 +105,7 @@
 Phase 2 - using <TYPEOF> log
         - zero log...
         - scan filesystem freespace and inode maps...
+bad agbno AGBNO in agfl, agno 0
         - found root inode chunk
 Phase 3 - for each AG...
         - scan and clear agi unlinked lists...

>  tests/xfs/010 |    7 ++++++-
>  tests/xfs/030 |    2 ++
>  2 files changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/xfs/010 b/tests/xfs/010
> index e220a651..b65dd3ba 100755
> --- a/tests/xfs/010
> +++ b/tests/xfs/010
> @@ -113,7 +113,12 @@ _check_scratch_fs
>  # nuke the finobt root, repair will have to regenerate from the inobt
>  _corrupt_finobt_root $SCRATCH_DEV
>  
> -_scratch_xfs_repair 2>&1 | _filter_repair_lostblocks
> +filter_finobt_repair() {
> +	sed -e '/^agi has bad CRC/d' | \
> +		_filter_repair_lostblocks
> +}
> +
> +_scratch_xfs_repair 2>&1 | filter_finobt_repair
>  
>  status=0
>  exit
> diff --git a/tests/xfs/030 b/tests/xfs/030
> index efdb6a18..ebe4c92a 100755
> --- a/tests/xfs/030
> +++ b/tests/xfs/030
> @@ -42,6 +42,8 @@ _check_ag()
>  			    -e '/^bad agbno AGBNO for finobt/d' \
>  			    -e '/^bad agbno AGBNO for rmapbt/d' \
>  			    -e '/^bad agbno AGBNO for refcntbt/d' \
> +			    -e '/^agf has bad CRC/d' \
> +			    -e '/^agi has bad CRC/d' \
>  			    -e '/^Missing reverse-mapping record.*/d' \
>  			    -e '/^unknown block state, ag AGNO, block.*/d'
>  	done
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] xfs/010,030: filter AG header CRC error warnings
  2020-07-29  4:49 ` Zorro Lang
@ 2020-07-29 14:50   ` Darrick J. Wong
  0 siblings, 0 replies; 6+ messages in thread
From: Darrick J. Wong @ 2020-07-29 14:50 UTC (permalink / raw)
  To: Eryu Guan, fstests

On Wed, Jul 29, 2020 at 12:49:56PM +0800, Zorro Lang wrote:
> On Tue, Jul 28, 2020 at 07:51:19PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> > 
> > Filter out the new AG header CRC verification warnings in xfs_repair
> > since these tests were built before that existed.
> > 
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > ---
> 
> Hi Darrick,
> 
> I still hit an error[1] on xfs/030 after merge your patch.

D'oh, I forgot to send that one out in this batch.  Will fix that
shortly.

--D

> Thanks,
> Zorro
> 
> # diff -u ./tests/xfs/030.out ./results//xfs/030.out.bad                                                          
> --- /root/git/xfstests-dev/tests/xfs/030.out    2020-03-12 11:22:50.063148796 +0800
> +++ /root/git/xfstests-dev/results//xfs/030.out.bad     2020-07-29 12:33:08.485428533 +0800
> @@ -105,6 +105,7 @@
>  Phase 2 - using <TYPEOF> log
>          - zero log...
>          - scan filesystem freespace and inode maps...
> +bad agbno AGBNO in agfl, agno 0
>          - found root inode chunk
>  Phase 3 - for each AG...
>          - scan and clear agi unlinked lists...
> 
> >  tests/xfs/010 |    7 ++++++-
> >  tests/xfs/030 |    2 ++
> >  2 files changed, 8 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tests/xfs/010 b/tests/xfs/010
> > index e220a651..b65dd3ba 100755
> > --- a/tests/xfs/010
> > +++ b/tests/xfs/010
> > @@ -113,7 +113,12 @@ _check_scratch_fs
> >  # nuke the finobt root, repair will have to regenerate from the inobt
> >  _corrupt_finobt_root $SCRATCH_DEV
> >  
> > -_scratch_xfs_repair 2>&1 | _filter_repair_lostblocks
> > +filter_finobt_repair() {
> > +	sed -e '/^agi has bad CRC/d' | \
> > +		_filter_repair_lostblocks
> > +}
> > +
> > +_scratch_xfs_repair 2>&1 | filter_finobt_repair
> >  
> >  status=0
> >  exit
> > diff --git a/tests/xfs/030 b/tests/xfs/030
> > index efdb6a18..ebe4c92a 100755
> > --- a/tests/xfs/030
> > +++ b/tests/xfs/030
> > @@ -42,6 +42,8 @@ _check_ag()
> >  			    -e '/^bad agbno AGBNO for finobt/d' \
> >  			    -e '/^bad agbno AGBNO for rmapbt/d' \
> >  			    -e '/^bad agbno AGBNO for refcntbt/d' \
> > +			    -e '/^agf has bad CRC/d' \
> > +			    -e '/^agi has bad CRC/d' \
> >  			    -e '/^Missing reverse-mapping record.*/d' \
> >  			    -e '/^unknown block state, ag AGNO, block.*/d'
> >  	done
> > 
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] xfs/010,030: filter AG header CRC error warnings
  2020-07-14  7:13 ` Zorro Lang
@ 2020-07-15 16:57   ` Darrick J. Wong
  0 siblings, 0 replies; 6+ messages in thread
From: Darrick J. Wong @ 2020-07-15 16:57 UTC (permalink / raw)
  To: Eryu Guan, fstests, xfs

On Tue, Jul 14, 2020 at 03:13:46PM +0800, Zorro Lang wrote:
> On Mon, Jul 13, 2020 at 11:49:30AM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> > 
> > Filter out the new AG header CRC verification warnings in xfs_repair
> > since these tests were built before that existed.
> > 
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > ---
> >  tests/xfs/010 |    6 +++++-
> >  tests/xfs/030 |    2 ++
> >  2 files changed, 7 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tests/xfs/010 b/tests/xfs/010
> > index c341795d..ec23507a 100755
> > --- a/tests/xfs/010
> > +++ b/tests/xfs/010
> > @@ -113,7 +113,11 @@ _check_scratch_fs
> >  # nuke the finobt root, repair will have to regenerate from the inobt
> >  _corrupt_finobt_root $SCRATCH_DEV
> >  
> > -_scratch_xfs_repair 2>&1 | sed -e '/^bad finobt block/d' | _filter_repair_lostblocks
> 
> I think this patch is based on another patch which hasn't been merged, right?
> Due to I can't find the *sed -e '/^bad finobt block/d'* on current xfstests-dev
> master branch, which HEAD is:
>   aae8fbec  generic/270: wait for fsstress processes to be killed

Oops, yeah, I forgot that my development branch has multiple patches to
those tests.  Now that xfsprogs for-next has updated I guess I should
clean all those up and send them for real.

--D

> Thanks,
> Zorro
> 
> > +filter_finobt_repair() {
> > +	sed -e '/^agi has bad CRC/d' -e '/^bad finobt block/d' | _filter_repair_lostblocks
> > +}
> > +
> > +_scratch_xfs_repair 2>&1 | filter_finobt_repair
> >  
> >  status=0
> >  exit
> > diff --git a/tests/xfs/030 b/tests/xfs/030
> > index 8f95331a..a270e36c 100755
> > --- a/tests/xfs/030
> > +++ b/tests/xfs/030
> > @@ -43,6 +43,8 @@ _check_ag()
> >  			    -e '/^bad agbno AGBNO for rmapbt/d' \
> >  			    -e '/^bad agbno AGBNO for refcntbt/d' \
> >  			    -e '/^bad inobt block count/d' \
> > +			    -e '/^agf has bad CRC/d' \
> > +			    -e '/^agi has bad CRC/d' \
> >  			    -e '/^bad finobt block count/d' \
> >  			    -e '/^Missing reverse-mapping record.*/d' \
> >  			    -e '/^unknown block state, ag AGNO, block.*/d'
> > 
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] xfs/010,030: filter AG header CRC error warnings
  2020-07-13 18:49 Darrick J. Wong
@ 2020-07-14  7:13 ` Zorro Lang
  2020-07-15 16:57   ` Darrick J. Wong
  0 siblings, 1 reply; 6+ messages in thread
From: Zorro Lang @ 2020-07-14  7:13 UTC (permalink / raw)
  To: Darrick J. Wong; +Cc: Eryu Guan, fstests, xfs

On Mon, Jul 13, 2020 at 11:49:30AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Filter out the new AG header CRC verification warnings in xfs_repair
> since these tests were built before that existed.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
>  tests/xfs/010 |    6 +++++-
>  tests/xfs/030 |    2 ++
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/xfs/010 b/tests/xfs/010
> index c341795d..ec23507a 100755
> --- a/tests/xfs/010
> +++ b/tests/xfs/010
> @@ -113,7 +113,11 @@ _check_scratch_fs
>  # nuke the finobt root, repair will have to regenerate from the inobt
>  _corrupt_finobt_root $SCRATCH_DEV
>  
> -_scratch_xfs_repair 2>&1 | sed -e '/^bad finobt block/d' | _filter_repair_lostblocks

I think this patch is based on another patch which hasn't been merged, right?
Due to I can't find the *sed -e '/^bad finobt block/d'* on current xfstests-dev
master branch, which HEAD is:
  aae8fbec  generic/270: wait for fsstress processes to be killed

Thanks,
Zorro

> +filter_finobt_repair() {
> +	sed -e '/^agi has bad CRC/d' -e '/^bad finobt block/d' | _filter_repair_lostblocks
> +}
> +
> +_scratch_xfs_repair 2>&1 | filter_finobt_repair
>  
>  status=0
>  exit
> diff --git a/tests/xfs/030 b/tests/xfs/030
> index 8f95331a..a270e36c 100755
> --- a/tests/xfs/030
> +++ b/tests/xfs/030
> @@ -43,6 +43,8 @@ _check_ag()
>  			    -e '/^bad agbno AGBNO for rmapbt/d' \
>  			    -e '/^bad agbno AGBNO for refcntbt/d' \
>  			    -e '/^bad inobt block count/d' \
> +			    -e '/^agf has bad CRC/d' \
> +			    -e '/^agi has bad CRC/d' \
>  			    -e '/^bad finobt block count/d' \
>  			    -e '/^Missing reverse-mapping record.*/d' \
>  			    -e '/^unknown block state, ag AGNO, block.*/d'
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] xfs/010,030: filter AG header CRC error warnings
@ 2020-07-13 18:49 Darrick J. Wong
  2020-07-14  7:13 ` Zorro Lang
  0 siblings, 1 reply; 6+ messages in thread
From: Darrick J. Wong @ 2020-07-13 18:49 UTC (permalink / raw)
  To: Eryu Guan; +Cc: fstests, xfs

From: Darrick J. Wong <darrick.wong@oracle.com>

Filter out the new AG header CRC verification warnings in xfs_repair
since these tests were built before that existed.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 tests/xfs/010 |    6 +++++-
 tests/xfs/030 |    2 ++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/tests/xfs/010 b/tests/xfs/010
index c341795d..ec23507a 100755
--- a/tests/xfs/010
+++ b/tests/xfs/010
@@ -113,7 +113,11 @@ _check_scratch_fs
 # nuke the finobt root, repair will have to regenerate from the inobt
 _corrupt_finobt_root $SCRATCH_DEV
 
-_scratch_xfs_repair 2>&1 | sed -e '/^bad finobt block/d' | _filter_repair_lostblocks
+filter_finobt_repair() {
+	sed -e '/^agi has bad CRC/d' -e '/^bad finobt block/d' | _filter_repair_lostblocks
+}
+
+_scratch_xfs_repair 2>&1 | filter_finobt_repair
 
 status=0
 exit
diff --git a/tests/xfs/030 b/tests/xfs/030
index 8f95331a..a270e36c 100755
--- a/tests/xfs/030
+++ b/tests/xfs/030
@@ -43,6 +43,8 @@ _check_ag()
 			    -e '/^bad agbno AGBNO for rmapbt/d' \
 			    -e '/^bad agbno AGBNO for refcntbt/d' \
 			    -e '/^bad inobt block count/d' \
+			    -e '/^agf has bad CRC/d' \
+			    -e '/^agi has bad CRC/d' \
 			    -e '/^bad finobt block count/d' \
 			    -e '/^Missing reverse-mapping record.*/d' \
 			    -e '/^unknown block state, ag AGNO, block.*/d'

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-29  2:51 [PATCH] xfs/010,030: filter AG header CRC error warnings Darrick J. Wong
2020-07-29  4:49 ` Zorro Lang
2020-07-29 14:50   ` Darrick J. Wong
  -- strict thread matches above, loose matches on Subject: below --
2020-07-13 18:49 Darrick J. Wong
2020-07-14  7:13 ` Zorro Lang
2020-07-15 16:57   ` Darrick J. Wong

FSTests Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/fstests/0 fstests/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 fstests fstests/ https://lore.kernel.org/fstests \
		fstests@vger.kernel.org
	public-inbox-index fstests

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.fstests


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git