* [PATCH] xfs/030: repair should actually find the zeroed block pointer in the agfl
@ 2020-07-29 14:53 Darrick J. Wong
2020-07-29 16:04 ` Zorro Lang
0 siblings, 1 reply; 3+ messages in thread
From: Darrick J. Wong @ 2020-07-29 14:53 UTC (permalink / raw)
To: Eryu Guan; +Cc: zlang, fstests
From: Darrick J. Wong <darrick.wong@oracle.com>
In xfs/030, at some point we zero the entire AGFL. Repair should really
find and complain about the AGFL list item that points to the AG
superblock.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
tests/xfs/030.out | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/xfs/030.out b/tests/xfs/030.out
index 4a7c4b8b..53299438 100644
--- a/tests/xfs/030.out
+++ b/tests/xfs/030.out
@@ -105,6 +105,7 @@ Phase 1 - find and verify superblock...
Phase 2 - using <TYPEOF> log
- zero log...
- scan filesystem freespace and inode maps...
+bad agbno AGBNO in agfl, agno 0
- found root inode chunk
Phase 3 - for each AG...
- scan and clear agi unlinked lists...
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs/030: repair should actually find the zeroed block pointer in the agfl
2020-07-29 14:53 [PATCH] xfs/030: repair should actually find the zeroed block pointer in the agfl Darrick J. Wong
@ 2020-07-29 16:04 ` Zorro Lang
2020-07-29 16:12 ` Darrick J. Wong
0 siblings, 1 reply; 3+ messages in thread
From: Zorro Lang @ 2020-07-29 16:04 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: fstests
On Wed, Jul 29, 2020 at 07:53:22AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> In xfs/030, at some point we zero the entire AGFL. Repair should really
> find and complain about the AGFL list item that points to the AG
> superblock.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> tests/xfs/030.out | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/xfs/030.out b/tests/xfs/030.out
> index 4a7c4b8b..53299438 100644
> --- a/tests/xfs/030.out
> +++ b/tests/xfs/030.out
> @@ -105,6 +105,7 @@ Phase 1 - find and verify superblock...
> Phase 2 - using <TYPEOF> log
> - zero log...
> - scan filesystem freespace and inode maps...
> +bad agbno AGBNO in agfl, agno 0
So this line is expected? This cause xfs/030 fails on old xfsprogs (on RHEL7 and
RHEL8).
> - found root inode chunk
> Phase 3 - for each AG...
> - scan and clear agi unlinked lists...
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs/030: repair should actually find the zeroed block pointer in the agfl
2020-07-29 16:04 ` Zorro Lang
@ 2020-07-29 16:12 ` Darrick J. Wong
0 siblings, 0 replies; 3+ messages in thread
From: Darrick J. Wong @ 2020-07-29 16:12 UTC (permalink / raw)
To: fstests
On Thu, Jul 30, 2020 at 12:04:38AM +0800, Zorro Lang wrote:
> On Wed, Jul 29, 2020 at 07:53:22AM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > In xfs/030, at some point we zero the entire AGFL. Repair should really
> > find and complain about the AGFL list item that points to the AG
> > superblock.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > ---
> > tests/xfs/030.out | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/xfs/030.out b/tests/xfs/030.out
> > index 4a7c4b8b..53299438 100644
> > --- a/tests/xfs/030.out
> > +++ b/tests/xfs/030.out
> > @@ -105,6 +105,7 @@ Phase 1 - find and verify superblock...
> > Phase 2 - using <TYPEOF> log
> > - zero log...
> > - scan filesystem freespace and inode maps...
> > +bad agbno AGBNO in agfl, agno 0
>
> So this line is expected? This cause xfs/030 fails on old xfsprogs (on RHEL7 and
> RHEL8).
Yes, because xfs_repair was changed in dcd6c2e1 ("xfs_repair: convert to
libxfs_verify_agbno") to complain about zeroed entries in the AGFL. I
guess now that that's upstream I should really change the commit log...
--D
>
> > - found root inode chunk
> > Phase 3 - for each AG...
> > - scan and clear agi unlinked lists...
> >
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-29 16:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-29 14:53 [PATCH] xfs/030: repair should actually find the zeroed block pointer in the agfl Darrick J. Wong
2020-07-29 16:04 ` Zorro Lang
2020-07-29 16:12 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).