From: Zorro Lang <zlang@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH v2] xfs/030: repair should actually find the zeroed block pointer in the agfl
Date: Thu, 30 Jul 2020 01:08:11 +0800 [thread overview]
Message-ID: <20200729170811.GJ2937@dhcp-12-102.nay.redhat.com> (raw)
In-Reply-To: <20200729161443.GA7600@magnolia>
On Wed, Jul 29, 2020 at 09:14:43AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> In xfs/030, we zero the entire AGFL which makes it corrupt because the
> AG superblock block is /never/ free. In commit dcd6c2e1 ("xfs_repair:
> convert to libxfs_verify_agbno") we enhanced repair to complain about
> zeroed entries in the AGFL, so add that to the golden output.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> v2: point out which commit we're testing
Thanks for pointing out the commit.
Reviewed-by: Zorro Lang <zlang@redhat.com>
> ---
> tests/xfs/030.out | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/xfs/030.out b/tests/xfs/030.out
> index 4a7c4b8b..53299438 100644
> --- a/tests/xfs/030.out
> +++ b/tests/xfs/030.out
> @@ -105,6 +105,7 @@ Phase 1 - find and verify superblock...
> Phase 2 - using <TYPEOF> log
> - zero log...
> - scan filesystem freespace and inode maps...
> +bad agbno AGBNO in agfl, agno 0
> - found root inode chunk
> Phase 3 - for each AG...
> - scan and clear agi unlinked lists...
>
prev parent reply other threads:[~2020-07-29 16:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 16:14 [PATCH v2] xfs/030: repair should actually find the zeroed block pointer in the agfl Darrick J. Wong
2020-07-29 17:08 ` Zorro Lang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200729170811.GJ2937@dhcp-12-102.nay.redhat.com \
--to=zlang@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).