FSTests Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v2] xfs/030: repair should actually find the zeroed block pointer in the agfl
@ 2020-07-29 16:14 Darrick J. Wong
  2020-07-29 17:08 ` Zorro Lang
  0 siblings, 1 reply; 2+ messages in thread
From: Darrick J. Wong @ 2020-07-29 16:14 UTC (permalink / raw)
  To: Eryu Guan; +Cc: zlang, fstests

From: Darrick J. Wong <darrick.wong@oracle.com>

In xfs/030, we zero the entire AGFL which makes it corrupt because the
AG superblock block is /never/ free.  In commit dcd6c2e1 ("xfs_repair:
convert to libxfs_verify_agbno") we enhanced repair to complain about
zeroed entries in the AGFL, so add that to the golden output.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
v2: point out which commit we're testing
---
 tests/xfs/030.out |    1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/xfs/030.out b/tests/xfs/030.out
index 4a7c4b8b..53299438 100644
--- a/tests/xfs/030.out
+++ b/tests/xfs/030.out
@@ -105,6 +105,7 @@ Phase 1 - find and verify superblock...
 Phase 2 - using <TYPEOF> log
         - zero log...
         - scan filesystem freespace and inode maps...
+bad agbno AGBNO in agfl, agno 0
         - found root inode chunk
 Phase 3 - for each AG...
         - scan and clear agi unlinked lists...

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] xfs/030: repair should actually find the zeroed block pointer in the agfl
  2020-07-29 16:14 [PATCH v2] xfs/030: repair should actually find the zeroed block pointer in the agfl Darrick J. Wong
@ 2020-07-29 17:08 ` Zorro Lang
  0 siblings, 0 replies; 2+ messages in thread
From: Zorro Lang @ 2020-07-29 17:08 UTC (permalink / raw)
  To: Darrick J. Wong; +Cc: fstests

On Wed, Jul 29, 2020 at 09:14:43AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> In xfs/030, we zero the entire AGFL which makes it corrupt because the
> AG superblock block is /never/ free.  In commit dcd6c2e1 ("xfs_repair:
> convert to libxfs_verify_agbno") we enhanced repair to complain about
> zeroed entries in the AGFL, so add that to the golden output.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> v2: point out which commit we're testing

Thanks for pointing out the commit.
Reviewed-by: Zorro Lang <zlang@redhat.com>

> ---
>  tests/xfs/030.out |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/xfs/030.out b/tests/xfs/030.out
> index 4a7c4b8b..53299438 100644
> --- a/tests/xfs/030.out
> +++ b/tests/xfs/030.out
> @@ -105,6 +105,7 @@ Phase 1 - find and verify superblock...
>  Phase 2 - using <TYPEOF> log
>          - zero log...
>          - scan filesystem freespace and inode maps...
> +bad agbno AGBNO in agfl, agno 0
>          - found root inode chunk
>  Phase 3 - for each AG...
>          - scan and clear agi unlinked lists...
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-29 16:14 [PATCH v2] xfs/030: repair should actually find the zeroed block pointer in the agfl Darrick J. Wong
2020-07-29 17:08 ` Zorro Lang

FSTests Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/fstests/0 fstests/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 fstests fstests/ https://lore.kernel.org/fstests \
		fstests@vger.kernel.org
	public-inbox-index fstests

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.fstests


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git