fstests.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eryu Guan <guan@eryu.me>
To: Hou Tao <houtao1@huawei.com>
Cc: richard@nod.at, guaneryu@gmail.com, yuchao0@huawei.com,
	fstests@vger.kernel.org
Subject: Re: [PATCH v2 1/2] generic: add test for race between listxattr and setxatr
Date: Wed, 2 Sep 2020 23:48:55 +0800	[thread overview]
Message-ID: <20200902154855.GF3853@desktop> (raw)
In-Reply-To: <c41ee2c2-f08f-be1f-b7a3-5cc52b49d29a@huawei.com>

On Mon, Aug 31, 2020 at 11:01:05AM +0800, Hou Tao wrote:
> Hi,
> 
> On 2020/8/31 0:23, Eryu Guan wrote:
> > On Sat, Aug 22, 2020 at 07:41:32PM +0800, Hou Tao wrote:
> >> Add reproducer for a bug on ubifs where listxattr() copies
> >> the newly created xattr names regardless of the remaining
> >> buffer size, fails the assertion of used buffer size,
> >> and may corrupt buffer memory.
> >>
> >> Signed-off-by: Hou Tao <houtao1@huawei.com>
> >> ---
> >> v2: accommodate f2fs by reducing the number of created xattrs for f2fs
> > 
> > Thanks for the test and revision! Is there a fix available for the ubifs
> > bug? If so would you please mention the kernel commit ID in commit log
> > as well?
> > 
> The fixes [1] have not been reviewed yet, so we may need to hold on until the fixes get merged ?
> 
> [1]: https://lore.kernel.org/linux-mtd/20200630130438.141649-1-houtao1@huawei.com/

It's better to have the fixes merged first, but we do merge tests before
the fixes landed in. But I'd like to see at least some reviews/acks on
the fixes first.

Thanks,
Eryu

  reply	other threads:[~2020-09-02 15:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-17  8:44 [PATCH 0/2] add tests for race between xattr read and write Hou Tao
2020-07-17  8:44 ` [PATCH 1/2] generic: add test for race between listxattr and setxatr Hou Tao
2020-07-20  3:40   ` Chao Yu
2020-08-22 11:41     ` [PATCH v2 " Hou Tao
2020-08-30 16:23       ` Eryu Guan
2020-08-31  1:19         ` Chao Yu
2020-08-31  3:01         ` Hou Tao
2020-09-02 15:48           ` Eryu Guan [this message]
2020-09-02 16:43       ` Darrick J. Wong
2020-07-17  8:44 ` [PATCH 2/2] generic: add test for race between getxattr and setxattr Hou Tao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200902154855.GF3853@desktop \
    --to=guan@eryu.me \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    --cc=houtao1@huawei.com \
    --cc=richard@nod.at \
    --cc=yuchao0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).