From: Eryu Guan <guan@eryu.me>
To: dsterba@suse.cz, Marcos Paulo de Souza <marcos@mpdesouza.com>,
dsterba@suse.com, linux-btrfs@vger.kernel.org,
fstests@vger.kernel.org,
Marcos Paulo de Souza <mpdesouza@suse.com>
Subject: Re: [PATCH] fstests: btrfs/218 check if mount opts are applied
Date: Wed, 2 Sep 2020 23:50:57 +0800 [thread overview]
Message-ID: <20200902155057.GG3853@desktop> (raw)
In-Reply-To: <20200831114503.GU28318@twin.jikos.cz>
On Mon, Aug 31, 2020 at 01:45:03PM +0200, David Sterba wrote:
> On Mon, Aug 31, 2020 at 12:15:19AM +0800, Eryu Guan wrote:
> > On Tue, Aug 04, 2020 at 05:56:48PM -0300, Marcos Paulo de Souza wrote:
> > > From: Marcos Paulo de Souza <mpdesouza@suse.com>
> > >
> > > This new test will apply different mount points and check if they were applied
> > > by reading /proc/self/mounts. Almost all available btrfs options are tested
> > > here, leaving only device=, which is tested in btrfs/125 and space_cache, tested
> > > in btrfs/131.
> > >
> > > This test does not apply any workload after the fs is mounted, just checks is
> > > the option was set/unset correctly.
> > >
> > > Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
> >
> > I'm seeing this diff when testing with v5.9-rc2 kernel and v5.4
> > btrfs-progs, is that expected?
> >
> > +Could not find 'relatime,compress=lzo,space_cache,subvolid' in 'rw,relatime,compress=lzo:3,space_cache,subvolid=5,subvol=/', using 'compress=lzo'
> > +Could not find 'relatime,compress=lzo,space_cache,subvolid' in 'rw,relatime,compress=lzo:3,space_cache,subvolid=5,subvol=/', using 'compress=lzo'
> > +Could not find 'relatime,compress-force=lzo,space_cache,subvolid' in 'rw,relatime,compress-force=lzo:4,space_cache,subvolid=5,subvol=/', using 'compress-force=lzo'
> > +Could not find 'relatime,compress-force=lzo,space_cache,subvolid' in 'rw,relatime,compress-force=lzo:4,space_cache,subvolid=5,subvol=/', using 'compress-force=lzo'
> > Silence is golden
>
> This should be fixed by 282dd7d77184 ("btrfs: reset compression level
> for lzo on remount") that is in v5.9-rc3.
Great!
Marcos, would you please refresh the patch to include the kernel fix in
commit log? Thanks!
Eryu
prev parent reply other threads:[~2020-09-02 15:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 20:56 [PATCH] fstests: btrfs/218 check if mount opts are applied Marcos Paulo de Souza
2020-08-16 15:35 ` Eryu Guan
2020-08-18 15:33 ` Josef Bacik
2020-08-30 16:15 ` Eryu Guan
2020-08-31 11:45 ` David Sterba
2020-09-02 15:50 ` Eryu Guan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200902155057.GG3853@desktop \
--to=guan@eryu.me \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=marcos@mpdesouza.com \
--cc=mpdesouza@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).