fstests.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eryu Guan <guan@eryu.me>
To: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
Cc: guaneryu@gmail.com, fstests@vger.kernel.org
Subject: Re: [PATCH] generic/611: Filter getfattr output
Date: Sun, 11 Oct 2020 13:06:23 +0800	[thread overview]
Message-ID: <20201011050622.GV3853@desktop> (raw)
In-Reply-To: <1602382464-1230-1-git-send-email-xuyang2018.jy@cn.fujitsu.com>

On Sun, Oct 11, 2020 at 10:14:24AM +0800, Yang Xu wrote:
> When using old version(such as getfattr 2.4.46) getfattr command, it
> has the following output,
> 
> touch file
> setfattr -n user.a file
> getfattr --absolute-names -n user.a file
> user.a
> 
> on new getfattr, it reports the following output,
> getfattr --absolute-names -n user.a file
> user.a=""

There's an helper to do this, _getfattr, so use it here instead of bare
$GETFATTR_PROG. For details please refer to commit 794f4594fbf4
("fstests: filter redundant output by getfattr")

Thanks,
Eryu

> 
> Filter doubt quotes and equals, so this case can pass.
> 
> Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
> ---
>  tests/generic/611     | 2 +-
>  tests/generic/611.out | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/generic/611 b/tests/generic/611
> index f4158bb3..c697b39a 100755
> --- a/tests/generic/611
> +++ b/tests/generic/611
> @@ -51,7 +51,7 @@ touch "${localfile}"
>  _scratch_cycle_mount
>  
>  # If the target bug isn't fixed, getfattr fails
> -${GETFATTR_PROG} --absolute-names -n user.a $localfile | grep 'user.a'
> +${GETFATTR_PROG} --absolute-names -n user.a $localfile | grep 'user.a' | sed 's/=""//g'
>  
>  status=0
>  exit
> diff --git a/tests/generic/611.out b/tests/generic/611.out
> index 1ab12434..8ccf52f0 100644
> --- a/tests/generic/611.out
> +++ b/tests/generic/611.out
> @@ -1,2 +1,2 @@
>  QA output created by 611
> -user.a=""
> +user.a
> -- 
> 2.23.0
> 
> 

  reply	other threads:[~2020-10-11  5:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-11  2:14 [PATCH] generic/611: Filter getfattr output Yang Xu
2020-10-11  5:06 ` Eryu Guan [this message]
2020-10-11  5:51   ` [PATCH v2] generic/611: Use _getfattr instead of GETFATTR_PROG Yang Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201011050622.GV3853@desktop \
    --to=guan@eryu.me \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    --cc=xuyang2018.jy@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).