FSTests Archive on lore.kernel.org
 help / color / Atom feed
From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Eric Biggers <ebiggers@kernel.org>
Cc: fstests@vger.kernel.org
Subject: Re: [xfstests-bld PATCH v2] gen-tarball: add 'set -e'
Date: Wed, 11 Nov 2020 22:51:49 -0500
Message-ID: <20201112035149.GA3477805@mit.edu> (raw)
In-Reply-To: <20201111213515.320012-1-ebiggers@kernel.org>

On Wed, Nov 11, 2020 at 01:35:15PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> 'make install' in xfstests was temporarily broken (it was broken by
> commit 10f3f9707cca and fixed by commit 1de2b58b8e29).  gen-tarball
> didn't notice this, resulting in test appliances being "successfully"
> built but not actually containing all the xfstests files.
> 
> Fix gen-tarball to check for errors by adding 'set -e'.  To make this
> work, adjust a few commands that are expected to fail.
> 
> Signed-off-by: Eric Biggers <ebiggers@google.com>

Thanks, applied.

						- Ted

      reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-01 17:24 [xfstests-bld PATCH] " Eric Biggers
2020-11-11 19:21 ` Eric Biggers
2020-11-11 21:25   ` Eric Biggers
2020-11-11 21:35     ` [xfstests-bld PATCH v2] " Eric Biggers
2020-11-12  3:51       ` Theodore Y. Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201112035149.GA3477805@mit.edu \
    --to=tytso@mit.edu \
    --cc=ebiggers@kernel.org \
    --cc=fstests@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

FSTests Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/fstests/0 fstests/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 fstests fstests/ https://lore.kernel.org/fstests \
		fstests@vger.kernel.org
	public-inbox-index fstests

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.fstests


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git