From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA619C2D0A3 for ; Thu, 12 Nov 2020 05:39:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 663762076E for ; Thu, 12 Nov 2020 05:39:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728344AbgKLFjZ (ORCPT ); Thu, 12 Nov 2020 00:39:25 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:52501 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728424AbgKLDvy (ORCPT ); Wed, 11 Nov 2020 22:51:54 -0500 Received: from callcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 0AC3pnE8001122 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 11 Nov 2020 22:51:50 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id 44635420107; Wed, 11 Nov 2020 22:51:49 -0500 (EST) Date: Wed, 11 Nov 2020 22:51:49 -0500 From: "Theodore Y. Ts'o" To: Eric Biggers Cc: fstests@vger.kernel.org Subject: Re: [xfstests-bld PATCH v2] gen-tarball: add 'set -e' Message-ID: <20201112035149.GA3477805@mit.edu> References: <20201111213515.320012-1-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201111213515.320012-1-ebiggers@kernel.org> Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org On Wed, Nov 11, 2020 at 01:35:15PM -0800, Eric Biggers wrote: > From: Eric Biggers > > 'make install' in xfstests was temporarily broken (it was broken by > commit 10f3f9707cca and fixed by commit 1de2b58b8e29). gen-tarball > didn't notice this, resulting in test appliances being "successfully" > built but not actually containing all the xfstests files. > > Fix gen-tarball to check for errors by adding 'set -e'. To make this > work, adjust a few commands that are expected to fail. > > Signed-off-by: Eric Biggers Thanks, applied. - Ted