From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Chandan Babu R <chandanrlinux@gmail.com>
Cc: fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 01/11] common/xfs: Add a helper to get an inode fork's extent count
Date: Fri, 13 Nov 2020 16:10:30 -0800 [thread overview]
Message-ID: <20201114001030.GB9695@magnolia> (raw)
In-Reply-To: <20201113112704.28798-2-chandanrlinux@gmail.com>
On Fri, Nov 13, 2020 at 04:56:53PM +0530, Chandan Babu R wrote:
> This commit adds the helper _scratch_get_iext_count() which returns an
> inode fork's extent count.
>
> Signed-off-by: Chandan Babu R <chandanrlinux@gmail.com>
> ---
> common/xfs | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/common/xfs b/common/xfs
> index 79dab058..45cd329c 100644
> --- a/common/xfs
> +++ b/common/xfs
> @@ -883,6 +883,28 @@ _scratch_get_bmx_prefix() {
> return 1
> }
>
> +_scratch_get_iext_count()
> +{
> + ino=$1
> + whichfork=$2
> +
> + case $whichfork in
> + "attr")
> + field=core.naextents
> + ;;
> + "data")
> + field=core.nextents
> + ;;
> + *)
> + return 1
> + esac
> +
> + nextents=$(_scratch_xfs_db -c "inode $ino" -c "print $field")
> + nextents=${nextents##${field} = }
This helper looks fine, but looking at the callers spread over the next
10 patches, I notice that you unmount to call this helper and
immediately remount the fs.
I wonder, is there a specific reason for grabbing the extent count that
way? You can extract the same info online with `xfs_io -c 'stat' /moo',
right?
--D
> +
> + echo $nextents
> +}
> +
> #
> # Ensures that we don't pass any mount options incompatible with XFS v4
> #
> --
> 2.28.0
>
next prev parent reply other threads:[~2020-11-14 0:10 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 11:26 [PATCH 00/11] xfs: Tests to check for inode fork extent count overflow detection Chandan Babu R
2020-11-13 11:26 ` [PATCH 01/11] common/xfs: Add a helper to get an inode fork's extent count Chandan Babu R
2020-11-14 0:10 ` Darrick J. Wong [this message]
2020-11-13 11:26 ` [PATCH 02/11] xfs: Check for extent overflow when trivally adding a new extent Chandan Babu R
2020-11-14 0:24 ` Darrick J. Wong
2020-11-17 14:12 ` Chandan Babu R
2020-11-18 2:30 ` Darrick J. Wong
2020-11-18 4:09 ` Chandan Babu R
2020-11-13 11:26 ` [PATCH 03/11] " Chandan Babu R
2020-11-14 0:18 ` Darrick J. Wong
2020-11-17 14:22 ` Chandan Babu R
2020-11-13 11:26 ` [PATCH 04/11] xfs: Check for extent overflow when punching a hole Chandan Babu R
2020-11-14 0:28 ` Darrick J. Wong
2020-11-17 14:26 ` Chandan Babu R
2020-11-13 11:26 ` [PATCH 05/11] xfs: Check for extent overflow when adding/removing xattrs Chandan Babu R
2020-11-14 0:34 ` Darrick J. Wong
2020-11-17 14:30 ` Chandan Babu R
2020-11-13 11:26 ` [PATCH 06/11] xfs: Check for extent overflow when adding/removing dir entries Chandan Babu R
2020-11-14 0:37 ` Darrick J. Wong
2020-11-17 14:50 ` Chandan Babu R
2020-11-13 11:26 ` [PATCH 07/11] xfs: Check for extent overflow when writing to unwritten extent Chandan Babu R
2020-11-14 0:39 ` Darrick J. Wong
2020-11-17 15:15 ` Chandan Babu R
2020-11-13 11:27 ` [PATCH 08/11] xfs: Check for extent overflow when moving extent from cow to data fork Chandan Babu R
2020-11-14 0:42 ` Darrick J. Wong
2020-11-18 5:20 ` Chandan Babu R
2020-11-13 11:27 ` [PATCH 09/11] xfs: Check for extent overflow when remapping an extent Chandan Babu R
2020-11-14 0:43 ` Darrick J. Wong
2020-11-13 11:27 ` [PATCH 10/11] xfs: Check for extent overflow when swapping extents Chandan Babu R
2020-11-14 0:08 ` Darrick J. Wong
2020-11-17 15:35 ` Chandan Babu R
2020-11-18 2:23 ` Darrick J. Wong
2020-11-13 11:27 ` [PATCH 11/11] xfs: Stress test with with bmap_alloc_minlen_extent error tag enabled Chandan Babu R
2020-11-14 0:06 ` Darrick J. Wong
2020-11-17 15:24 ` Chandan Babu R
2020-11-13 11:29 ` [PATCH 00/11] xfs: Tests to check for inode fork extent count overflow detection Chandan Babu R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201114001030.GB9695@magnolia \
--to=darrick.wong@oracle.com \
--cc=chandanrlinux@gmail.com \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).