From: "André Almeida" <andrealmeid@collabora.com>
To: fstests@vger.kernel.org
Cc: krisman@collabora.com, kernel@collabora.com,
"Lakshmipathi . G" <lakshmipathi.ganapathi@collabora.com>,
"Eryu Guan" <guaneryu@gmail.com>,
"André Almeida" <andrealmeid@collabora.com>
Subject: [PATCH 2/2] generic/556: Fix rename test
Date: Wed, 24 Mar 2021 19:48:17 -0300 [thread overview]
Message-ID: <20210324224817.103503-2-andrealmeid@collabora.com> (raw)
In-Reply-To: <20210324224817.103503-1-andrealmeid@collabora.com>
Casefold rename test should check if renaming a file to an equivalent
name fails as expect (e.g. renaming from "file.txt" to "FILE.TXT") and
`mv` correctly identifies that those names refers to the same file.
Currently, the test doesn't do what is expected given that it doesn't
have the file to be renamed, and `mv` returns "No such file or
directory". Fix that by creating test files and checking the correct
output.
Fixes: 12b7dddbc265fcb ("generic: Add tests for filename casefolding feature")
Signed-off-by: André Almeida <andrealmeid@collabora.com>
---
tests/generic/556 | 4 +++-
tests/generic/556.out | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/generic/556 b/tests/generic/556
index 3efd0510..3145188c 100755
--- a/tests/generic/556
+++ b/tests/generic/556
@@ -341,8 +341,10 @@ test_file_rename()
mkdir -p ${basedir}
_casefold_set_attr ${basedir}
+ touch ${basedir}/rename
+
# Move to an equivalent name should not work
- mv ${basedir}/rename ${basedir}/rename 2>&1 | \
+ mv ${basedir}/rename ${basedir}/RENAME 2>&1 | \
_filter_scratch
_casefold_check_exact_name ${basedir} "rename" || \
diff --git a/tests/generic/556.out b/tests/generic/556.out
index 47656065..f9dd9542 100644
--- a/tests/generic/556.out
+++ b/tests/generic/556.out
@@ -5,7 +5,7 @@ SCRATCH_MNT/casefold_flag_removal Casefold
SCRATCH_MNT/casefold_flag_removal Casefold
SCRATCH_MNT/flag_inheritance/d1/d2/d3 Casefold
SCRATCH_MNT/symlink/ind1/TARGET
-mv: cannot stat 'SCRATCH_MNT/rename/rename': No such file or directory
+mv: 'SCRATCH_MNT/rename/rename' and 'SCRATCH_MNT/rename/RENAME' are the same file
# file: SCRATCH_MNT/xattrs/x
user.foo="bar"
--
2.31.0
next prev parent reply other threads:[~2021-03-24 22:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 22:48 [PATCH 1/2] common: Escape SCRATCH_DEV variable André Almeida
2021-03-24 22:48 ` André Almeida [this message]
2021-03-24 22:55 ` Gabriel Krisman Bertazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210324224817.103503-2-andrealmeid@collabora.com \
--to=andrealmeid@collabora.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=lakshmipathi.ganapathi@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).