FSTests Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] generic/629: add missing copy_range command check
@ 2021-03-29  1:40 Chao Yu
  2021-03-29 18:44 ` Darrick J. Wong
  0 siblings, 1 reply; 2+ messages in thread
From: Chao Yu @ 2021-03-29  1:40 UTC (permalink / raw)
  To: fstests; +Cc: guan, chao, Chao Yu

Otherwise, if xfs_io doesn't support this command, it will report
that filesystem fails on this testcase.

Signed-off-by: Chao Yu <yuchao0@huawei.com>
---
 tests/generic/629 | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/generic/629 b/tests/generic/629
index ad86ab5bb0c0..13d433a4e470 100755
--- a/tests/generic/629
+++ b/tests/generic/629
@@ -36,6 +36,7 @@ _cleanup()
 _supported_fs generic
 _require_dm_target error
 _require_xfs_io_command "chattr" "s"
+_require_xfs_io_command "copy_range"
 _require_scratch
 
 rm -f $seqres.full
-- 
2.29.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] generic/629: add missing copy_range command check
  2021-03-29  1:40 [PATCH] generic/629: add missing copy_range command check Chao Yu
@ 2021-03-29 18:44 ` Darrick J. Wong
  0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2021-03-29 18:44 UTC (permalink / raw)
  To: Chao Yu; +Cc: fstests, guan, chao

On Mon, Mar 29, 2021 at 09:40:13AM +0800, Chao Yu wrote:
> Otherwise, if xfs_io doesn't support this command, it will report
> that filesystem fails on this testcase.
> 
> Signed-off-by: Chao Yu <yuchao0@huawei.com>

Yep, thanks for catching this.
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  tests/generic/629 | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/generic/629 b/tests/generic/629
> index ad86ab5bb0c0..13d433a4e470 100755
> --- a/tests/generic/629
> +++ b/tests/generic/629
> @@ -36,6 +36,7 @@ _cleanup()
>  _supported_fs generic
>  _require_dm_target error
>  _require_xfs_io_command "chattr" "s"
> +_require_xfs_io_command "copy_range"
>  _require_scratch
>  
>  rm -f $seqres.full
> -- 
> 2.29.2
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-29  1:40 [PATCH] generic/629: add missing copy_range command check Chao Yu
2021-03-29 18:44 ` Darrick J. Wong

FSTests Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/fstests/0 fstests/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 fstests fstests/ https://lore.kernel.org/fstests \
		fstests@vger.kernel.org
	public-inbox-index fstests

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.fstests


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git