From: "Darrick J. Wong" <djwong@kernel.org>
To: Zorro Lang <zlang@redhat.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH v2] generic/233,270: unlimit the max locked memory size for io_uring
Date: Mon, 29 Mar 2021 21:55:21 -0700 [thread overview]
Message-ID: <20210330045521.GT1670408@magnolia> (raw)
In-Reply-To: <20210330005942.536259-1-zlang@redhat.com>
On Tue, Mar 30, 2021 at 08:59:42AM +0800, Zorro Lang wrote:
> The ltp/fsstress always fails on io_uring_queue_init() by returnning
> ENOMEM. Due to io_uring accounts memory it needs under the rlimit
> memlocked option, which can be quite low on some setups, especially
> on 64K pagesize machine. root isn't under this restriction, but
> regular users are. So only g/233 and g/270 which use $qa_user to run
> fsstress are failed.
>
> To avoid this failure, set max locked memory to unlimited before doing
> fsstress, then restore it after test done.
>
> Signed-off-by: Zorro Lang <zlang@redhat.com>
> ---
>
> Hi,
>
> V2 removed `ulimit -l $lmem`, due to each case runs in child process, won't
> affect other testing.
>
> Thanks,
> Zorro
>
> tests/generic/233 | 6 ++++++
> tests/generic/270 | 6 ++++++
> 2 files changed, 12 insertions(+)
>
> diff --git a/tests/generic/233 b/tests/generic/233
> index 7eda5774..cc794c79 100755
> --- a/tests/generic/233
> +++ b/tests/generic/233
> @@ -43,6 +43,12 @@ _fsstress()
> -f rename=10 -f fsync=2 -f write=15 -f dwrite=15 \
> -n $count -d $out -p 7`
>
> + # io_uring accounts memory it needs under the rlimit memlocked option,
> + # which can be quite low on some setups (especially 64K pagesize). root
> + # isn't under this restriction, but regular users are. To avoid the
> + # io_uring_queue_init fail on ENOMEM, set max locked memory to unlimited
> + # temporarily.
> + ulimit -l unlimited
> echo "fsstress $args" >> $seqres.full
> if ! su $qa_user -c "$FSSTRESS_PROG $args" | tee -a $seqres.full | _filter_num
/me kinda feels like this should be refactored into a common helper, but
somehow when I try to picture that in my head all I can see is a
screeching nightmare of bash goop so feel free to ignore me. :)
--D
> then
> diff --git a/tests/generic/270 b/tests/generic/270
> index 3d8656d4..e93940ef 100755
> --- a/tests/generic/270
> +++ b/tests/generic/270
> @@ -37,6 +37,12 @@ _workout()
> cp $FSSTRESS_PROG $tmp.fsstress.bin
> $SETCAP_PROG cap_chown=epi $tmp.fsstress.bin
>
> + # io_uring accounts memory it needs under the rlimit memlocked option,
> + # which can be quite low on some setups (especially 64K pagesize). root
> + # isn't under this restriction, but regular users are. To avoid the
> + # io_uring_queue_init fail on ENOMEM, set max locked memory to unlimited
> + # temporarily.
> + ulimit -l unlimited
> (su $qa_user -c "$tmp.fsstress.bin $args" &) > /dev/null 2>&1
>
> echo "Run dd writers in parallel"
> --
> 2.30.2
>
prev parent reply other threads:[~2021-03-30 4:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 0:59 [PATCH v2] generic/233,270: unlimit the max locked memory size for io_uring Zorro Lang
2021-03-30 4:55 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210330045521.GT1670408@magnolia \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).