fstests.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Brauner <christian.brauner@ubuntu.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Eryu Guan <guan@eryu.me>, Christian Brauner <brauner@kernel.org>,
	fstests@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	"Darrick J . Wong" <djwong@kernel.org>,
	David Howells <dhowells@redhat.com>,
	Amir Goldstein <amir73il@gmail.com>
Subject: Re: [PATCH v12 2/6] generic/632: add fstests for idmapped mounts
Date: Mon, 12 Apr 2021 13:54:26 +0200	[thread overview]
Message-ID: <20210412115426.a4bzsx4cp7jhx2ou@wittgenstein> (raw)
In-Reply-To: <YHOW7DN51YuYgLPM@mit.edu>

On Sun, Apr 11, 2021 at 08:40:12PM -0400, Theodore Ts'o wrote:
> On Sun, Apr 11, 2021 at 05:32:23PM +0200, Christian Brauner wrote:
> > Ah, ok I didn't know this needed to go in there. I thinke the following
> > might be enough. Are you able to simply apply it on top?
> > 
> > diff --git a/common/rc b/common/rc
> > index 351996fc..bd913d13 100644
> > --- a/common/rc
> > +++ b/common/rc
> > @@ -2047,6 +2047,16 @@ _require_mount_setattr()
> >  # test whether idmapped mounts are supported
> >  _require_idmapped_mounts()
> >  {
> > +       case "$FSTYP" in
> > +       xfs)
> > +               ;;
> > +       ext4)
> > +               ;;
> > +       *)
> > +               _notrun "Filesystem $FSTYP does not support idmapped mounts yet"
> > +               ;;
> > +       esac
> > +
> 
> Is there any way we can ask the kernel which file systems support
> idmapped mounts?  That way, the tests will do the right thing when run
> on older LTS kernels, and if a distribution backports idmapped support
> for some file system into their kernel, again, the right thing can
> happen automatically.

So we can detect it pretty reliably at runtime by trying whether we can
create an idmapped mount on the given filesystem. That is enough for the
idmapped mount tests here but of course has at least two drawbacks:
1. there might be scenarios where we get false negatives
   (e.g. open_tree() could fail for a lack of permissions or sm else,
   kernel might be compiled without userns support etc. pp)
2. it's heavy in so far as we have to do the whole exercise of creating
   a detached mount
So having a reliable way to detect whether or not the underlying fs
supports it could be worth it (My hope was for the fsinfo() API to grow
this "feature check" ability but oh well.).

One possibility might be to extend fstatfs() and steal one u32 from the
padding that is currently in there?

> 
> If you can't do this by checking to see if the file system will
> support a particular mount option, or some other run-time test, for
> ext4 we can signal this by checking for the existence of a file in
> /sys/fs/ext4/features, such as /sys/fs/ext4/features/fast_commit.
> (Grep for EXT4_ATTR_FEATURE and ATTR_LIST in fs/ext4/sysfs.c; it
> requires adding two lines to advertise a new ext4 feature.)

I wonder if this wouldn't be nice to have independent of whether or not
there is another way to detect it?
I'm would think that people like to see all new ext4 features listed in
there. Even if this is technically a generic vfs feature.

Christian

  reply	other threads:[~2021-04-12 11:54 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-28 22:33 [PATCH v12 0/6] fstests: add idmapped mounts tests Christian Brauner
2021-03-28 22:33 ` [PATCH v12 1/6] generic/631: add test for detached mount propagation Christian Brauner
2021-03-28 22:33 ` [PATCH v12 3/6] common/rc: add _scratch_{u}mount_idmapped() helpers Christian Brauner
2021-03-28 22:33 ` [PATCH v12 4/6] common/quota: move _qsetup() helper to common code Christian Brauner
2021-03-28 22:33 ` [PATCH v12 5/6] xfs/529: quotas and idmapped mounts Christian Brauner
2021-03-28 22:34 ` [PATCH v12 6/6] xfs/530: quotas on " Christian Brauner
     [not found] ` <20210328223400.1800301-3-brauner@kernel.org>
2021-04-11 14:30   ` [PATCH v12 2/6] generic/632: add fstests for " Eryu Guan
2021-04-11 15:12     ` Christian Brauner
2021-04-11 15:18       ` Christian Brauner
2021-04-11 15:21         ` Eryu Guan
2021-04-11 15:32           ` Christian Brauner
2021-04-12  0:40             ` Theodore Ts'o
2021-04-12 11:54               ` Christian Brauner [this message]
2021-04-12 22:41                 ` Theodore Ts'o
2021-04-14 20:47                   ` [PATCH -RFC] ext4: add feature file to advertise that ext4 supports " Theodore Ts'o
2021-04-15  5:54                     ` Christoph Hellwig
2021-04-15  7:49                       ` Christian Brauner
2021-04-15  7:55                         ` Christoph Hellwig
2021-04-15  8:13                           ` Christian Brauner
2021-04-15 14:59                         ` Theodore Ts'o
2021-04-12  7:22             ` [PATCH v12 2/6] generic/632: add fstests for " Christoph Hellwig
2021-04-12  7:30               ` Christian Brauner
2021-04-11 15:19       ` Eryu Guan
2021-04-11 14:37 ` [PATCH v12 0/6] fstests: add idmapped mounts tests Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210412115426.a4bzsx4cp7jhx2ou@wittgenstein \
    --to=christian.brauner@ubuntu.com \
    --cc=amir73il@gmail.com \
    --cc=brauner@kernel.org \
    --cc=dhowells@redhat.com \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=guan@eryu.me \
    --cc=hch@lst.de \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).