From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: guaneryu@gmail.com, linux-xfs@vger.kernel.org,
fstests@vger.kernel.org, guan@eryu.me
Subject: Re: [PATCH 7/9] generic/620: fix order of require_scratch calls
Date: Wed, 14 Apr 2021 07:20:06 +0100 [thread overview]
Message-ID: <20210414062006.GI1602505@infradead.org> (raw)
In-Reply-To: <161836231396.2754991.1877515727730919792.stgit@magnolia>
On Tue, Apr 13, 2021 at 06:05:14PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> _require_scratch_16T_support does not itself check that the scratch
> device exists, which means that it depends on someone else to call
> _require_scratch. Document this dependency and fix this test so that we
> can run:
>
> ./check --exact-order generic/374 generic/620
>
> on an ext4 filesystem without g/620 tripping over the mess left by g/374
> when it calls _notrun.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2021-04-14 6:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 1:04 [PATCHSET 0/9] fstests: random fixes Darrick J. Wong
2021-04-14 1:04 ` [PATCH 1/9] xfs/506: fix regression on freshly quotachecked filesystem Darrick J. Wong
2021-04-14 6:12 ` Christoph Hellwig
2021-04-14 1:04 ` [PATCH 2/9] generic/563: selectively remove the io cgroup controller Darrick J. Wong
2021-04-14 6:13 ` Christoph Hellwig
2021-04-14 1:04 ` [PATCH 3/9] xfs/521,530: refactor scratch fs check Darrick J. Wong
2021-04-14 6:15 ` Christoph Hellwig
2021-04-14 1:04 ` [PATCH 4/9] common/dump: filter out xfs_restore messages about fallocate failures Darrick J. Wong
2021-04-14 6:16 ` Christoph Hellwig
2021-04-14 1:05 ` [PATCH 5/9] common/dmthin: make this work with external log devices Darrick J. Wong
2021-04-14 6:17 ` Christoph Hellwig
2021-04-18 12:25 ` Eryu Guan
2021-04-18 14:44 ` Theodore Ts'o
2021-04-19 2:04 ` Dave Chinner
2021-04-19 16:14 ` Darrick J. Wong
2021-04-14 1:05 ` [PATCH 6/9] misc: replace more open-coded _scratch_xfs_db calls Darrick J. Wong
2021-04-14 6:18 ` Christoph Hellwig
2021-04-14 1:05 ` [PATCH 7/9] generic/620: fix order of require_scratch calls Darrick J. Wong
2021-04-14 6:20 ` Christoph Hellwig [this message]
2021-04-14 1:05 ` [PATCH 8/9] generic/{094,225}: skip test when the xfs rt extent size is larger than 1 fsb Darrick J. Wong
2021-04-14 6:20 ` Christoph Hellwig
2021-04-14 1:05 ` [PATCH 9/9] xfs/305: make sure that fsstress is still running when we quotaoff Darrick J. Wong
2021-04-14 6:21 ` Christoph Hellwig
2021-04-14 14:38 ` Darrick J. Wong
2021-04-20 6:21 ` Christoph Hellwig
2021-04-18 12:29 ` [PATCHSET 0/9] fstests: random fixes Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210414062006.GI1602505@infradead.org \
--to=hch@infradead.org \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).