From: Christoph Hellwig <hch@infradead.org>
To: Theodore Ts'o <tytso@mit.edu>
Cc: fstests@vger.kernel.org, guaneryu@gmail.com
Subject: Re: [PATCH] common/rc: teach _require_scratch_swapfile() that swap does not work with DAX
Date: Tue, 20 Apr 2021 07:25:49 +0100 [thread overview]
Message-ID: <20210420062549.GB3525612@infradead.org> (raw)
In-Reply-To: <20210418161925.240995-1-tytso@mit.edu>
On Sun, Apr 18, 2021 at 12:19:25PM -0400, Theodore Ts'o wrote:
> The statement, "ext* and xfs have supported all variants of swap files
> since their introduction, so swapon should not fail," is not quite
> completely true. In particular, swapon does not work if the DAX is
> active on a swapfile, and that would be true if the file system is
> mounted with -o dax.
>
> So if swapon fails, check to see if the swapfile has the
> STATX_ATTR_DAX attribute set, and if so, issue a _notrun instead of a
> _fail.
Isn't the fact that swapon doesn't work on DAX files a back? The
swap I/O path couldn't care less if the file is marked as DAX or not.
prev parent reply other threads:[~2021-04-20 6:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-18 16:19 [PATCH] common/rc: teach _require_scratch_swapfile() that swap does not work with DAX Theodore Ts'o
2021-04-20 6:25 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210420062549.GB3525612@infradead.org \
--to=hch@infradead.org \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).