Re: [PATCH v3 3/3] fstests: generic: add checks for zoned block device

["Darrick J. Wong" <djwong@kernel.org>]

On Mon, Aug 16, 2021 at 08:35:10PM +0900, Naohiro Aota wrote:
> Modify generic tests to require non-zoned block device
> 
> generic/108 is disabled on zoned block device because the LVM device not
> always aligned to the zone boundary.
> 
> generic/471 is disabled because we cannot enable NoCoW on zoned btrfs.
> 
> generic/570 is disabled because swap file which require nocow is not usable
> on zoned btrfs.
> 
> Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>

I'm surprised that only three generic tests needed the annotation, but
the logic makes sense, so
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  tests/generic/108 | 2 ++
>  tests/generic/471 | 2 ++
>  tests/generic/570 | 2 ++
>  3 files changed, 6 insertions(+)
> 
> diff --git a/tests/generic/108 b/tests/generic/108
> index b7797e8fac2b..6e1ea5b9d20a 100755
> --- a/tests/generic/108
> +++ b/tests/generic/108
> @@ -36,6 +36,8 @@ _require_scratch_nocheck
>  _require_block_device $SCRATCH_DEV
>  _require_scsi_debug
>  _require_command "$LVM_PROG" lvm
> +# We cannot ensure the Logical Volume is aligned to the zone boundary
> +_require_non_zoned_device $SCRATCH_DEV
>  
>  lvname=lv_$seq
>  vgname=vg_$seq
> diff --git a/tests/generic/471 b/tests/generic/471
> index dab06f3a315c..fbd0b12a9e3a 100755
> --- a/tests/generic/471
> +++ b/tests/generic/471
> @@ -37,6 +37,8 @@ mkdir $testdir
>  # all filesystems, use a NOCOW file on btrfs.
>  if [ $FSTYP == "btrfs" ]; then
>  	_require_chattr C
> +	# Zoned btrfs does not support NOCOW
> +	_require_non_zoned_device $TEST_DEV
>  	touch $testdir/f1
>  	$CHATTR_PROG +C $testdir/f1
>  fi
> diff --git a/tests/generic/570 b/tests/generic/570
> index 7d03acfe3c44..126b222d10d2 100755
> --- a/tests/generic/570
> +++ b/tests/generic/570
> @@ -25,6 +25,8 @@ _supported_fs generic
>  _require_test_program swapon
>  _require_scratch_nocheck
>  _require_block_device $SCRATCH_DEV
> +# We cannot create swap on a zoned device because it can cause random write IOs
> +_require_non_zoned_device "$SCRATCH_DEV"
>  test -e /dev/snapshot && _notrun "userspace hibernation to swap is enabled"
>  
>  $MKSWAP_PROG "$SCRATCH_DEV" >> $seqres.full
> -- 
> 2.32.0
>