From: Jan Kara <jack@suse.cz>
To: Boyang Xue <bxue@redhat.com>
Cc: fstests@vger.kernel.org, Jan Kara <jack@suse.cz>,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: regression test for "tune2fs -l" after ext4 shutdown
Date: Wed, 18 Aug 2021 16:26:01 +0200 [thread overview]
Message-ID: <20210818142601.GF28119@quack2.suse.cz> (raw)
In-Reply-To: <CAHLe9YZcuo2K6ELT0p1c6sfzwkSgikeiyNect4phEoCt8vTPXw@mail.gmail.com>
On Wed 18-08-21 21:20:44, Boyang Xue wrote:
> > > +
> > > +# real QA test starts here
> > > +_supported_fs ext4
> >
> > I'm wondering if this case can be a generic case, there's nothing
> > ext4 specified operations, except this line:
> >
> > "$TUNE2FS_PROG -l $SCRATCH_DEV"
> >
> > Hmm... if we can change this line to something likes _get_fs_super(),
> > it might help to make this test to be a generic test.
>
> I think this bug is heavily related to "tune2fs", ext4 only. So I
> guess an ext4 only test is enough?
FWIW I agree with Boyang here. For this test to make sense for any other
filesystem other the filesystem would need to read fs metadata through
buffer cache in _get_fs_super(). Furthermore it is somewhat ext2/3/4
specific (due to historical reasons) that reading superblock from the
buffer cache of a mounted filesystem is expected to result in something
sensible. Usually this is plain unsupported use...
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2021-08-18 14:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 8:40 [PATCH] ext4: regression test for "tune2fs -l" after ext4 shutdown bxue
2021-08-18 11:45 ` Zorro Lang
2021-08-18 13:20 ` Boyang Xue
2021-08-18 14:26 ` Jan Kara [this message]
2021-08-18 17:16 ` Zorro Lang
2021-08-18 16:59 ` Zorro Lang
2021-08-19 5:48 ` Boyang Xue
2021-08-19 6:06 ` Eryu Guan
2021-08-19 6:30 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210818142601.GF28119@quack2.suse.cz \
--to=jack@suse.cz \
--cc=bxue@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).