fstests.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
To: fstests@vger.kernel.org
Cc: Naohiro Aota <naohiro.aota@wdc.com>,
	Johannes Thumshirn <johannes.thumshirn@wdc.com>,
	Damien Le Moal <Damien.LeMoal@wdc.com>,
	Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Subject: [PATCH v2 0/3] fstests: Fix order of _require_scratch* and _require_dm_target
Date: Wed,  8 Sep 2021 17:37:12 +0900	[thread overview]
Message-ID: <20210908083715.1831067-1-shinichiro.kawasaki@wdc.com> (raw)

Test cases with dm_target shall call _require_scratch* before
_require_dm_target. However, three test cases generic/628, generic/629 and
btrfs/146 do not follow this rule and result in unexpected failures. The first
patch in this series fixes the failures in generic/628 and generic/629. The
second patch fixes it in btrfs/146. The last patch improves _require_dm_target
to prevent the failure in the future test cases to be added.

The failure was found with generic/628 and generic/629. I checked all existing
test cases and found btrfs/146 also has the issue.

Changes from v1:
* Changed fix approach according to comment on the list
* Added fix for btrfs/146 as the 2nd patch
* Separated improvement in _require_dm_target as the last patch

Shin'ichiro Kawasaki (3):
  generic/{628,629}: Fix order of _require_scratch* and
  btrfs/146: Add _require_scratch_dev_pool before _require_dm_target
  common/rc: Check call order of _require_dm_target and

 common/rc         | 3 +++
 tests/btrfs/146   | 1 +
 tests/generic/628 | 2 +-
 tests/generic/629 | 2 +-
 4 files changed, 6 insertions(+), 2 deletions(-)


             reply	other threads:[~2021-09-08  8:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-08  8:37 Shin'ichiro Kawasaki [this message]
2021-09-08  8:37 ` [PATCH v2 1/3] generic/{628,629}: " Shin'ichiro Kawasaki
2021-09-08 17:04   ` Johannes Thumshirn
2021-09-08  8:37 ` [PATCH v2 2/3] btrfs/146: Add _require_scratch_dev_pool before _require_dm_target Shin'ichiro Kawasaki
2021-09-08 17:05   ` Johannes Thumshirn
2021-09-12  9:30   ` Eryu Guan
2021-09-08  8:37 ` [PATCH v2 3/3] common/rc: Check call order of _require_dm_target and _require_scratch* Shin'ichiro Kawasaki
2021-09-10  0:48   ` Dave Chinner
2021-09-10  6:34     ` Shinichiro Kawasaki
2021-09-12  9:17       ` Eryu Guan
2021-09-12 23:28         ` Shinichiro Kawasaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210908083715.1831067-1-shinichiro.kawasaki@wdc.com \
    --to=shinichiro.kawasaki@wdc.com \
    --cc=Damien.LeMoal@wdc.com \
    --cc=fstests@vger.kernel.org \
    --cc=johannes.thumshirn@wdc.com \
    --cc=naohiro.aota@wdc.com \
    --subject='Re: [PATCH v2 0/3] fstests: Fix order of _require_scratch* and _require_dm_target' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).