From: "Darrick J. Wong" <djwong@kernel.org>
To: Catherine Hoang <catherine.hoang@oracle.com>
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org,
allison.henderson@oracle.com
Subject: Re: [PATCH v2 4/4] common/log: Fix *_dump_log routines for ext4
Date: Thu, 7 Oct 2021 09:15:48 -0700 [thread overview]
Message-ID: <20211007161548.GA24282@magnolia> (raw)
In-Reply-To: <20211007002641.714906-5-catherine.hoang@oracle.com>
On Thu, Oct 07, 2021 at 12:26:41AM +0000, Catherine Hoang wrote:
> dumpe2fs -h displays the superblock contents, not the journal contents.
> Use the logdump utility to dump the contents of the journal.
>
> Signed-off-by: Catherine Hoang <catherine.hoang@oracle.com>
> ---
> common/log | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/common/log b/common/log
> index 0a9aaa7f..154f3959 100644
> --- a/common/log
> +++ b/common/log
> @@ -229,7 +229,7 @@ _scratch_dump_log()
> $DUMP_F2FS_PROG $SCRATCH_DEV
> ;;
> ext4)
> - $DUMPE2FS_PROG -h $SCRATCH_DEV
> + $DEBUGFS_PROG -R "logdump -a" $SCRATCH_DEV
Hmm. Some of the tests call _require_command on various e2fsprogs
programs. However, debugfs has been a part of e2fsprogs since forever
and e2fsprogs is a required fstests dependency, so I guess those
callsites are unnecessary (but otherwise benign). For that matter, I
think e2fsprogs is an 'essential' package on Debian and almost always
installed by Linux distros. I think that means it's safe to assume that
debugfs is present.
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ;;
> *)
> ;;
> @@ -246,7 +246,7 @@ _test_dump_log()
> $DUMP_F2FS_PROG $TEST_DEV
> ;;
> ext4)
> - $DUMPE2FS_PROG -h $TEST_DEV
> + $DEBUGFS_PROG -R "logdump -a" $TEST_DEV
> ;;
> *)
> ;;
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-10-07 16:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 0:26 [PATCH v2 0/4] Dump log cleanups Catherine Hoang
2021-10-07 0:26 ` [PATCH v2 1/4] xfstests: Rename _scratch_inject_logprint to _scratch_remount_dump_log Catherine Hoang
2021-10-07 16:20 ` Darrick J. Wong
2021-10-07 0:26 ` [PATCH v2 2/4] xfstests: Rename _test_inject_logprint to _test_remount_dump_log Catherine Hoang
2021-10-07 16:19 ` Darrick J. Wong
2021-10-07 0:26 ` [PATCH v2 3/4] common/log: Move *_dump_log routines to common/log Catherine Hoang
2021-10-07 16:19 ` Darrick J. Wong
2021-10-07 0:26 ` [PATCH v2 4/4] common/log: Fix *_dump_log routines for ext4 Catherine Hoang
2021-10-07 16:15 ` Darrick J. Wong [this message]
2021-10-07 18:24 ` [External] : " Catherine Hoang
2021-10-08 17:49 ` Allison Henderson
2021-10-08 19:06 ` Catherine Hoang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211007161548.GA24282@magnolia \
--to=djwong@kernel.org \
--cc=allison.henderson@oracle.com \
--cc=catherine.hoang@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).