From: David Disseldorp <ddiss@suse.de>
To: Leah Rumancik <leah.rumancik@gmail.com>
Cc: fstests@vger.kernel.org, zlang@redhat.com, djwong@kernel.org,
amir73il@gmail.com
Subject: Re: [PATCH v3] selftest: add tests for debugging testing setup
Date: Wed, 22 Feb 2023 15:37:09 +0100 [thread overview]
Message-ID: <20230222153709.1ac846a5@echidna.fritz.box> (raw)
In-Reply-To: <20230221223649.3616254-1-leah.rumancik@gmail.com>
On Tue, 21 Feb 2023 14:36:49 -0800, Leah Rumancik wrote:
> Many people have developed infrastructure around xfstests. In order to
> test a setup, it would be helpful to have dummy tests that have
> consistent test outcomes. Add a new test folder with the following
> tests:
>
> selftest/001 pass
> selftest/002 fail from output mismatch
> selftest/003 fail via _fail
> selftest/004 skip
> selftest/005 crash
> selftest/006 hang
>
> Also, create two new groups: 'selftest' which includes tests 001-004 and
> 'dangerous_selftest' which includes tests 005-006. The selftests will
> not run unless explicitly specified.
>
> Signed-off-by: Leah Rumancik <leah.rumancik@gmail.com>
> ---
> v2 -> v3:
> - remove selftest folder from SRC_GROUPS
> - add README.selftest
> - remove trailing blank lines from tests
Looks good.
Reviewed-by: David Disseldorp <ddiss@suse.de>
Some sort of meta-check to confirm that the selftest results match
expectations would be IMO helpful, but that can come later.
next prev parent reply other threads:[~2023-02-22 14:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 22:36 [PATCH v3] selftest: add tests for debugging testing setup Leah Rumancik
2023-02-22 14:30 ` Zorro Lang
2023-02-22 17:45 ` Leah Rumancik
2023-02-22 14:37 ` David Disseldorp [this message]
2023-02-22 16:43 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230222153709.1ac846a5@echidna.fritz.box \
--to=ddiss@suse.de \
--cc=amir73il@gmail.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=leah.rumancik@gmail.com \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).