fstests.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: Rodrigo Campos <rodrigo@sdfg.com.ar>
Cc: fstests@vger.kernel.org, Giuseppe Scrivano <gscrivan@redhat.com>
Subject: Re: [PATCH 08/11] vfs: Export test_setup() and test_cleanup()
Date: Tue, 7 Mar 2023 17:51:48 +0100	[thread overview]
Message-ID: <20230307165148.ogfe5xmgxpqmv54n@wittgenstein> (raw)
In-Reply-To: <20230307114507.332309-9-rodrigo@sdfg.com.ar>

On Tue, Mar 07, 2023 at 12:45:04PM +0100, Rodrigo Campos wrote:
> Future patches will call existing test inside another test, so we need
> to properly setup the test environment.
> 
> Signed-off-by: Rodrigo Campos <rodrigo@sdfg.com.ar>
> ---
>  src/vfs/vfstest.c |  4 ++--
>  src/vfs/vfstest.h | 10 ++++++++++
>  2 files changed, 12 insertions(+), 2 deletions(-)
>  create mode 100644 src/vfs/vfstest.h
> 
> diff --git src/vfs/vfstest.c src/vfs/vfstest.c
> index 3ec65dff..9e15ad9a 100644
> --- src/vfs/vfstest.c
> +++ src/vfs/vfstest.c
> @@ -81,7 +81,7 @@ static void stash_overflowgid(struct vfstest_info *info)
>  	info->t_overflowgid = atoi(buf);
>  }
>  
> -static void test_setup(struct vfstest_info *info)
> +void test_setup(struct vfstest_info *info)
>  {
>  	if (mkdirat(info->t_mnt_fd, T_DIR1, 0777))
>  		die("failure: mkdirat");
> @@ -94,7 +94,7 @@ static void test_setup(struct vfstest_info *info)
>  		die("failure: fchmod");
>  }
>  
> -static void test_cleanup(struct vfstest_info *info)
> +void test_cleanup(struct vfstest_info *info)
>  {
>  	safe_close(info->t_dir1_fd);
>  	if (rm_r(info->t_mnt_fd, T_DIR1))
> diff --git src/vfs/vfstest.h src/vfs/vfstest.h
> new file mode 100644
> index 00000000..352b57d5
> --- /dev/null
> +++ src/vfs/vfstest.h
> @@ -0,0 +1,10 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +
> +#ifndef __VFSTEST_H
> +#define __VFSTEST_H
> +
> +void test_setup(struct vfstest_info *info);
> +void test_cleanup(struct vfstest_info *info);
> +
> +
> +#endif /* __IDMAPPED_MOUNTS_H */


s/__IDMAPPED_MOUNTS_H/__VFSTEST_H/ ?

  reply	other threads:[~2023-03-07 16:56 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-07 11:44 [PATCH 00/11] Tests for idmapped tmpfs Rodrigo Campos
2023-03-07 11:44 ` [PATCH 01/11] vfs: Don't open-code safe_close() Rodrigo Campos
2023-03-07 16:42   ` Christian Brauner
2023-03-07 11:44 ` [PATCH 02/11] vfs: Fix documentation typo Rodrigo Campos
2023-03-07 16:43   ` Christian Brauner
2023-03-07 11:44 ` [PATCH 03/11] vfs: Fix race condition on get_userns_fd() Rodrigo Campos
2023-03-07 16:46   ` Christian Brauner
2023-03-07 17:32     ` Rodrigo Campos
2023-03-07 11:45 ` [PATCH 04/11] vfs: Make switch_userns set PR_SET_DUMPABLE Rodrigo Campos
2023-03-07 16:47   ` Christian Brauner
2023-03-07 11:45 ` [PATCH 05/11] vfs: Specify wether a test is run inside a userns or not Rodrigo Campos
2023-03-07 11:45 ` [PATCH 06/11] vfs: Prepare tests in &s_idmapped_mounts to be reused inside a userns Rodrigo Campos
2023-03-07 16:50   ` Christian Brauner
2023-03-07 23:34     ` Rodrigo Campos
2023-03-13 10:37       ` Christian Brauner
2023-03-07 11:45 ` [PATCH 07/11] vfs: Make idmapped core tests public Rodrigo Campos
2023-03-07 16:51   ` Christian Brauner
2023-03-07 11:45 ` [PATCH 08/11] vfs: Export test_setup() and test_cleanup() Rodrigo Campos
2023-03-07 16:51   ` Christian Brauner [this message]
2023-03-07 17:11     ` Rodrigo Campos
2023-03-07 11:45 ` [PATCH 09/11] vfs: Add DIR0 constant Rodrigo Campos
2023-03-07 16:53   ` Christian Brauner
2023-03-07 17:33     ` Rodrigo Campos
2023-03-07 11:45 ` [PATCH 10/11] vfs: Add tmpfs tests for idmap mounts Rodrigo Campos
2023-03-07 11:45 ` [PATCH 11/11] vfs: Use tabs to indent, not spaces Rodrigo Campos
2023-03-07 16:55   ` Christian Brauner
2023-03-07 17:10     ` Rodrigo Campos
2023-03-08 17:27     ` Zorro Lang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230307165148.ogfe5xmgxpqmv54n@wittgenstein \
    --to=brauner@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=gscrivan@redhat.com \
    --cc=rodrigo@sdfg.com.ar \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).