From: Christoph Hellwig <hch@lst.de>
To: Zorro Lang <zlang@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, fstests@vger.kernel.org
Subject: Re: [PATCH 1/2] generic: add a test for device removal with dirty data
Date: Mon, 7 Aug 2023 13:21:00 +0200 [thread overview]
Message-ID: <20230807112100.GB15405@lst.de> (raw)
In-Reply-To: <20230806141145.2lpntvfn7kqglads@zlang-mailbox>
On Sun, Aug 06, 2023 at 10:11:45PM +0800, Zorro Lang wrote:
> On Mon, Jul 24, 2023 at 08:29:26AM -0700, Christoph Hellwig wrote:
> > Test the removal of the underlying device when the file system still
> > has dirty data.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > ---
>
> After I merge this case, it always hit a kernel warning about a "possible
> circular locking dependency detected", no matter on ext4 [1] or xfs. This
> test isn't hang actually. But it always fail this test (got a .dmesg file).
> Any ideas about that?
That's because xfs and ext4 do the blkdev_put of the non-main devices
in ->put_super and thus inside s_umount. It's actually an old issue,
we now just trigger it reliably. We'll need to move the dropping into
->kill_sb after dropping ->s_umount. This has been on my plate for
a while.
next prev parent reply other threads:[~2023-08-07 11:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 15:29 add device removal test v3 Christoph Hellwig
2023-07-24 15:29 ` [PATCH 1/2] generic: add a test for device removal with dirty data Christoph Hellwig
2023-07-24 18:23 ` Andrey Albershteyn
2023-07-24 19:52 ` Christoph Hellwig
2023-07-25 9:44 ` Andrey Albershteyn
2023-07-25 15:33 ` Darrick J. Wong
2023-08-06 14:11 ` Zorro Lang
2023-08-07 11:21 ` Christoph Hellwig [this message]
2023-07-24 15:29 ` [PATCH 2/2] generic: add a test for device removal without " Christoph Hellwig
2023-07-25 15:33 ` Darrick J. Wong
2023-07-25 7:28 ` add device removal test v3 Zorro Lang
-- strict thread matches above, loose matches on Subject: below --
2023-07-11 10:09 add device removal test v2 Christoph Hellwig
2023-07-11 10:09 ` [PATCH 1/2] generic: add a test for device removal with dirty data Christoph Hellwig
2023-07-18 10:34 ` Zorro Lang
2023-06-01 9:42 add device removal test Christoph Hellwig
2023-06-01 9:42 ` [PATCH 1/2] generic: add a test for device removal with dirty data Christoph Hellwig
2023-06-01 15:25 ` Darrick J. Wong
2023-06-01 15:27 ` Christoph Hellwig
2023-06-01 16:04 ` Darrick J. Wong
2023-06-02 4:13 ` Christoph Hellwig
2023-06-02 10:58 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230807112100.GB15405@lst.de \
--to=hch@lst.de \
--cc=fstests@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).