From: "Darrick J. Wong" <djwong@kernel.org>
To: zlang@redhat.com
Cc: fstests@vger.kernel.org, linux-xfs@vger.kernel.org, guan@eryu.me
Subject: [PATCH v1.1 1/4] xfs/270: fix rocompat regex
Date: Tue, 26 Mar 2024 19:48:52 -0700 [thread overview]
Message-ID: <20240327024852.GV6390@frogsfrogsfrogs> (raw)
In-Reply-To: <171150740360.3286541.8931841089205728326.stgit@frogsfrogsfrogs>
From: Darrick J. Wong <djwong@kernel.org>
This test fails with the fsverity patchset because the rocompat feature
bit for verity is 0x10. The regular expression used to check if the
output is hexadecimal requires a single-digit answer, which is no longer
the case.
Fixes: 5bb78c56ef ("xfs/270: Fix ro mount failure when nrext64 option is enabled")
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
v1.1: remove debug message
---
tests/xfs/270 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/xfs/270 b/tests/xfs/270
index 4e4f767dc1..0c3ddc5b61 100755
--- a/tests/xfs/270
+++ b/tests/xfs/270
@@ -30,7 +30,7 @@ _require_scratch_shutdown
# change this case.
set_bad_rocompat() {
ro_compat=$(_scratch_xfs_get_metadata_field "features_ro_compat" "sb 0")
- echo $ro_compat | grep -q -E '^0x[[:xdigit:]]$'
+ echo $ro_compat | grep -q -E '^0x[[:xdigit:]]+$'
if [[ $? != 0 ]]; then
echo "features_ro_compat has an invalid value."
return 1
next prev parent reply other threads:[~2024-03-27 2:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 2:43 [PATCHSET] fstests: random fixes for v2024.02.09 Darrick J. Wong
2024-03-27 2:43 ` [PATCH 1/4] xfs/270: fix rocompat regex Darrick J. Wong
2024-03-27 2:48 ` Darrick J. Wong [this message]
2024-03-27 11:32 ` [PATCH v1.1 " Christoph Hellwig
2024-03-27 2:43 ` [PATCH 2/4] xfs/176: fix stupid failure Darrick J. Wong
2024-03-27 11:32 ` Christoph Hellwig
2024-03-27 2:43 ` [PATCH 3/4] generic/{166,167,333,334,671}: actually fill the filesystem with snapshots Darrick J. Wong
2024-03-27 16:59 ` Christoph Hellwig
2024-03-29 23:07 ` Darrick J. Wong
2024-03-30 5:39 ` Christoph Hellwig
2024-03-30 7:14 ` Zorro Lang
2024-03-27 2:43 ` [PATCH 4/4] generic: test MADV_POPULATE_READ with IO errors Darrick J. Wong
2024-03-30 7:12 ` Zorro Lang
2024-03-30 15:31 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240327024852.GV6390@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).