FSTests Archive on lore.kernel.org
 help / color / Atom feed
From: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>,
	Eryu Guan <guaneryu@gmail.com>, fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH] xfs/010,030: filter AG header CRC error warnings
Date: Fri, 28 Aug 2020 09:33:48 +0800
Message-ID: <2825f60b-8f64-a070-c593-bea5be3b6a6c@cn.fujitsu.com> (raw)
In-Reply-To: <e23c06f4-e4e8-b916-e4f5-946cd3e01936@cn.fujitsu.com>

Hi Darrick,Eryu

ping. Or I miss something?
> Hi Darrick, Eryu
> 
> It seems that fstests missed this patch. I used lastest xfsprogs 
> (include commit a891d871 xfs_repair: complain about ag header crc 
> errors) and xfs/030 still fails because of CRC verification warnings.
> 
> Best Regards
> Yang Xu
>> On Wed, Jul 29, 2020 at 12:49:56PM +0800, Zorro Lang wrote:
>>> On Tue, Jul 28, 2020 at 07:51:19PM -0700, Darrick J. Wong wrote:
>>>> From: Darrick J. Wong <darrick.wong@oracle.com>
>>>>
>>>> Filter out the new AG header CRC verification warnings in xfs_repair
>>>> since these tests were built before that existed.
>>>>
>>>> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
>>>> ---
>>>
>>> Hi Darrick,
>>>
>>> I still hit an error[1] on xfs/030 after merge your patch.
>>
>> D'oh, I forgot to send that one out in this batch.  Will fix that
>> shortly.
>>
>> --D
>>
>>> Thanks,
>>> Zorro
>>>
>>> # diff -u ./tests/xfs/030.out ./results//xfs/030.out.bad
>>> --- /root/git/xfstests-dev/tests/xfs/030.out    2020-03-12 
>>> 11:22:50.063148796 +0800
>>> +++ /root/git/xfstests-dev/results//xfs/030.out.bad     2020-07-29 
>>> 12:33:08.485428533 +0800
>>> @@ -105,6 +105,7 @@
>>>   Phase 2 - using <TYPEOF> log
>>>           - zero log...
>>>           - scan filesystem freespace and inode maps...
>>> +bad agbno AGBNO in agfl, agno 0
>>>           - found root inode chunk
>>>   Phase 3 - for each AG...
>>>           - scan and clear agi unlinked lists...
>>>
>>>>   tests/xfs/010 |    7 ++++++-
>>>>   tests/xfs/030 |    2 ++
>>>>   2 files changed, 8 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/tests/xfs/010 b/tests/xfs/010
>>>> index e220a651..b65dd3ba 100755
>>>> --- a/tests/xfs/010
>>>> +++ b/tests/xfs/010
>>>> @@ -113,7 +113,12 @@ _check_scratch_fs
>>>>   # nuke the finobt root, repair will have to regenerate from the inobt
>>>>   _corrupt_finobt_root $SCRATCH_DEV
>>>> -_scratch_xfs_repair 2>&1 | _filter_repair_lostblocks
>>>> +filter_finobt_repair() {
>>>> +    sed -e '/^agi has bad CRC/d' | \
>>>> +        _filter_repair_lostblocks
>>>> +}
>>>> +
>>>> +_scratch_xfs_repair 2>&1 | filter_finobt_repair
>>>>   status=0
>>>>   exit
>>>> diff --git a/tests/xfs/030 b/tests/xfs/030
>>>> index efdb6a18..ebe4c92a 100755
>>>> --- a/tests/xfs/030
>>>> +++ b/tests/xfs/030
>>>> @@ -42,6 +42,8 @@ _check_ag()
>>>>                   -e '/^bad agbno AGBNO for finobt/d' \
>>>>                   -e '/^bad agbno AGBNO for rmapbt/d' \
>>>>                   -e '/^bad agbno AGBNO for refcntbt/d' \
>>>> +                -e '/^agf has bad CRC/d' \
>>>> +                -e '/^agi has bad CRC/d' \
>>>>                   -e '/^Missing reverse-mapping record.*/d' \
>>>>                   -e '/^unknown block state, ag AGNO, block.*/d'
>>>>       done
>>>>
>>>
>>
>>



  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-29  2:51 Darrick J. Wong
2020-07-29  4:49 ` Zorro Lang
2020-07-29 14:50   ` Darrick J. Wong
2020-08-26  8:23     ` Yang Xu
2020-08-28  1:33       ` Yang Xu [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-07-13 18:49 Darrick J. Wong
2020-07-14  7:13 ` Zorro Lang
2020-07-15 16:57   ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2825f60b-8f64-a070-c593-bea5be3b6a6c@cn.fujitsu.com \
    --to=xuyang2018.jy@cn.fujitsu.com \
    --cc=darrick.wong@oracle.com \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

FSTests Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/fstests/0 fstests/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 fstests fstests/ https://lore.kernel.org/fstests \
		fstests@vger.kernel.org
	public-inbox-index fstests

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.fstests


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git