From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3DBBC352A3 for ; Fri, 7 Feb 2020 02:09:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8A8AA222D9 for ; Fri, 7 Feb 2020 02:09:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=toxicpanda-com.20150623.gappssmtp.com header.i=@toxicpanda-com.20150623.gappssmtp.com header.b="H888Es7o" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727003AbgBGCJj (ORCPT ); Thu, 6 Feb 2020 21:09:39 -0500 Received: from mail-qt1-f195.google.com ([209.85.160.195]:34156 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727028AbgBGCJi (ORCPT ); Thu, 6 Feb 2020 21:09:38 -0500 Received: by mail-qt1-f195.google.com with SMTP id h12so779607qtu.1 for ; Thu, 06 Feb 2020 18:09:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=O0CBq/56D0+K1fC96UPE9jCeddc6RxcWot0DdNZr0Sw=; b=H888Es7oDBIH41b5KqN35iQiWEqLb1JEGLYAw/h8QUCtW0sJoGy3/mvgLq5sWoq/vm T1FjLkAQrcNLAph6FYnjj9eWAY3Dqqk+nKH2YYoTFhE8eSQgrY0OY/HzTL1oAv1CBC4s N2dCEJOGGzUdor1ZbUMjrgVYDpWcdH1IY/KS7a7GhmBKFv3rlqlb6LQfG7vgu7gkcUj4 QqnkqxmA25yJkeqH7KSxy7K+c7dhu8OTF8i2GkiyZwGCw8Cirih2qnKAzX3S5zOABX3e JIg1aC4Vukc/Wtcf5TLDnqaUIRVCl9yJ6E2Zic86ylbFMHEWEFmZH1uFfbvlnl3MZR29 Su1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=O0CBq/56D0+K1fC96UPE9jCeddc6RxcWot0DdNZr0Sw=; b=XjUq0f+IMFiG996+c8weP+RcUUvm/ATZZCfkoJXXzUh+kHXU/gTltT/a9TWOYpiU+m qNQAkaWG+kYxO/H2SNLPwXZ42S1LY3g5IeMMTLJPjRXYwDGWpaz45XTx4Gg3/uKbR/di MDyOGqMvBKvIYySQuUDuH49jF+NuxxQisy9OkazDXdIzmVbOOnvaQObv+LPy5w5RS4dq 9o/LOKj7XG2pHs1WWJrOlhVX6LxjK4UMSNASn1IQH5E9AdVdrtHADjat6b6+7X+paIPA aQP+6ACAfPVYnx0kXnqE0Zw4brjjVmm+VLhqDJf37jfhS9gpwjuBiFNzIZrlBZ2LehUA KK3Q== X-Gm-Message-State: APjAAAXfaogoqr0KOXWcsYZF5A2V2NlEFyfL2w1Xp0+2wtLLAvSDQqw+ wPHVyCV21XyiK+voMqT4g9Nikzdygrg= X-Google-Smtp-Source: APXvYqwxkJK0Pa0EwwdSQEHeT5ZSQEE/4CiXf6knsVakI24Rm1GWNv5LqozCEUZ/DHMK7XuTx0vPGw== X-Received: by 2002:ac8:7243:: with SMTP id l3mr5318414qtp.139.1581041376233; Thu, 06 Feb 2020 18:09:36 -0800 (PST) Received: from [192.168.1.106] ([107.15.81.208]) by smtp.gmail.com with ESMTPSA id v18sm596999qkg.67.2020.02.06.18.09.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Feb 2020 18:09:35 -0800 (PST) Subject: Re: [PATCH 1/3] fstests: btrfs: Use word mathcing for _btrfs_get_subvolid() To: Qu Wenruo , fstests@vger.kernel.org, linux-btrfs@vger.kernel.org References: <20200207015942.9079-1-wqu@suse.com> <20200207015942.9079-2-wqu@suse.com> From: Josef Bacik Message-ID: <2b676a46-96b5-c461-667a-d85ae6e8a70d@toxicpanda.com> Date: Thu, 6 Feb 2020 21:09:34 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <20200207015942.9079-2-wqu@suse.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org On 2/6/20 8:59 PM, Qu Wenruo wrote: > Current _btrfs_get_subvolid() can't handle the following case at all: > # btrfs subvol list $SCRATCH_MNT > ID 256 gen 9 top level 5 path subv1 > ID 257 gen 7 top level 256 path subv1/subv2 > ID 258 gen 8 top level 256 path subv1/subv3 > ID 259 gen 9 top level 256 path subv1/subv4 > > If we call "_btrfs_get_subvolid $SCRATCH_MNT subv1" we will get a list > of all subvolumes, not the subvolid of subv1. > > To address this problem, we go egrep to match $name which starts with a > space, and at the end of a line. > So that all other subvolumes won't hit. > > Suggested-by: Josef Bacik > Signed-off-by: Qu Wenruo Reviewed-by: Josef Bacik Thanks, Josef