From: Nikolay Borisov <nborisov@suse.com>
To: Eryu Guan <guan@eryu.me>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] btrfs/024: Remove no longer valid test
Date: Sun, 30 Aug 2020 22:30:39 +0300 [thread overview]
Message-ID: <35e0d5a5-3bc1-9e59-e01e-0645f7c08a84@suse.com> (raw)
In-Reply-To: <20200830160825.GB3853@desktop>
On 30.08.20 г. 19:08 ч., Eryu Guan wrote:
> Hi Nikolay,
>
> On Mon, Aug 17, 2020 at 04:40:26PM +0300, Nikolay Borisov wrote:
>> Kernel commit "btrfs: add missing check for nocow and compression inode
>> flags" invalidates the "file compressed, fs mounted with nodatacow"
>> mode due to doing more rigorous flags validation, just remove the test.
>>
>> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
>
> I applied this patch, but left patch 2 and 3, as Anand suggested minor
> updates, and I assume you'll send new version of patch 2 and 3 :)
Please merge the patches as is, I don't intend on sending v2.
>
> Thanks,
> Eryu
>
>> ---
>> V2:
>> * Also remove the output
>>
>> tests/btrfs/024 | 7 -------
>> tests/btrfs/024.out | 3 ---
>> 2 files changed, 10 deletions(-)
>>
>> diff --git a/tests/btrfs/024 b/tests/btrfs/024
>> index 0c2ffd7389ab..bcb9048da636 100755
>> --- a/tests/btrfs/024
>> +++ b/tests/btrfs/024
>> @@ -42,13 +42,6 @@ __workout()
>> $XFS_IO_PROG -f -c "pwrite 0 1M" -c "fsync" $work_file | _filter_xfs_io
>> }
>>
>> -echo "*** test nodatacow"
>> -_scratch_mkfs > /dev/null 2>&1
>> -_scratch_mount "-o nodatacow"
>> -__workout
>> -_scratch_unmount
>> -_check_scratch_fs
>> -
>> echo "*** test compress=no"
>> _scratch_mkfs > /dev/null 2>&1
>> _scratch_mount "-o compress=no"
>> diff --git a/tests/btrfs/024.out b/tests/btrfs/024.out
>> index 7eacb0aca674..33c4f49366fd 100644
>> --- a/tests/btrfs/024.out
>> +++ b/tests/btrfs/024.out
>> @@ -1,7 +1,4 @@
>> QA output created by 024
>> -*** test nodatacow
>> -wrote 1048576/1048576 bytes at offset 0
>> -XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
>> *** test compress=no
>> wrote 1048576/1048576 bytes at offset 0
>> XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
>> --
>> 2.17.1
>
prev parent reply other threads:[~2020-08-30 19:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 10:37 [PATCH 1/3] btrfs/024: Remove no longer valid test Nikolay Borisov
2020-08-17 10:37 ` [PATCH 2/3] btrfs/173: Adjust compress file check Nikolay Borisov
2020-08-17 10:47 ` Anand Jain
2020-08-17 10:37 ` [PATCH 3/3] btrfs/174: Adjust error message when setting compressed flag Nikolay Borisov
2020-08-17 10:49 ` Anand Jain
2020-08-17 14:24 ` Marcos Paulo de Souza
2020-08-17 12:20 ` [PATCH 1/3] btrfs/024: Remove no longer valid test Nikolay Borisov
2020-08-17 13:40 ` [PATCH v2] " Nikolay Borisov
2020-08-17 14:17 ` Marcos Paulo de Souza
2020-08-30 16:08 ` Eryu Guan
2020-08-30 19:30 ` Nikolay Borisov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35e0d5a5-3bc1-9e59-e01e-0645f7c08a84@suse.com \
--to=nborisov@suse.com \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).