From: Marcos Paulo de Souza <mpdesouza@suse.de>
To: Anand Jain <anand.jain@oracle.com>, fstests@vger.kernel.org
Cc: linux-btrfs@vger.kernel.org, mpdesouza@suse.com
Subject: Re: [PATCH v2] fstests: common/btrfs: use complete sub command
Date: Mon, 10 Feb 2020 22:11:31 -0300 [thread overview]
Message-ID: <3e45f382a11ccff9aa1f63210ae86764116d1959.camel@suse.de> (raw)
In-Reply-To: <1581381911-6727-1-git-send-email-anand.jain@oracle.com>
On Tue, 2020-02-11 at 08:45 +0800, Anand Jain wrote:
> Search for 'subvolume' in the file common/btrfs failed to find all of
> them, leading to a wrong inference for a moment.
>
> Make sure we use the full subcommand name in the btrfs command.
Hum, in my tests realted to subvol delete by id[1], this function
successfully got the subvolid for subvol names like subvol[123].. Do
you have a case where it fails?
>
> Signed-off-by: Anand Jain <anand.jain@oracle.com>
> Marcos Paulo de Souza <mpdesouza@suse.com>
Here you meant I reviewed the first version of the patch?
Thanks,
Marcos
[1]:
https://lore.kernel.org/linux-btrfs/20200207131951.15859-3-marcos.souza.org@gmail.com/
> ---
> v2: Update commit log.
>
> common/btrfs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/btrfs b/common/btrfs
> index 19ac7cc4b18c..33ad7e3b41cc 100644
> --- a/common/btrfs
> +++ b/common/btrfs
> @@ -7,7 +7,7 @@ _btrfs_get_subvolid()
> mnt=$1
> name=$2
>
> - $BTRFS_UTIL_PROG sub list $mnt | grep $name | awk '{ print $2
> }'
> + $BTRFS_UTIL_PROG subvolume list $mnt | grep $name | awk '{
> print $2 }'
> }
>
> # _require_btrfs_command <command> [<subcommand>|<option>]
prev parent reply other threads:[~2020-02-11 1:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 0:45 [PATCH v2] fstests: common/btrfs: use complete sub command Anand Jain
2020-02-11 1:11 ` Marcos Paulo de Souza [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e45f382a11ccff9aa1f63210ae86764116d1959.camel@suse.de \
--to=mpdesouza@suse.de \
--cc=anand.jain@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=mpdesouza@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).