FSTests Archive on lore.kernel.org
 help / color / Atom feed
From: Anand Jain <anand.jain@oracle.com>
To: Nikolay Borisov <nborisov@suse.com>, guan@eryu.me
Cc: linux-btrfs@vger.kernel.org, fstests@vger.kernel.org
Subject: Re: [PATCH] btrfs/162: Stop using device mount option
Date: Thu, 30 Jul 2020 10:57:27 +0800
Message-ID: <437821d1-5fc4-77e2-d66d-ab63e935c15b@oracle.com> (raw)
In-Reply-To: <20200724131250.3377-1-nborisov@suse.com>

On 24/7/20 9:12 pm, Nikolay Borisov wrote:
> btrfs is clever enough to figure out which devices constitute the sprout
> fs even without specifying them explicitly with -o device.

   holds good only in this test case.

> Additionally,
> explicitly settings the devices via -o device reduces coverage of the
> test since it didn't detect breakage a local change introduced.

  We relay on unmount not freeing up the btrfs_device.

> Without
> -o device instead this breakage was detected.

  That's like testing two things in one test case. I am ok.

> 
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>

  Reviewed-by: Anand.Jain@oracle.com

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-24 13:12 Nikolay Borisov
2020-07-30  2:57 ` Anand Jain [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=437821d1-5fc4-77e2-d66d-ab63e935c15b@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=fstests@vger.kernel.org \
    --cc=guan@eryu.me \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=nborisov@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

FSTests Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/fstests/0 fstests/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 fstests fstests/ https://lore.kernel.org/fstests \
		fstests@vger.kernel.org
	public-inbox-index fstests

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.fstests


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git