From: Xiaoli Feng <xifeng@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Eryu Guan <guaneryu@gmail.com>,
Yang Xu <xuyang2018.ky@cn.fujitsu.com>,
fstests <fstests@vger.kernel.org>,
xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs/148: sort attribute list output
Date: Fri, 6 Dec 2019 01:51:16 -0500 (EST) [thread overview]
Message-ID: <443856653.20019671.1575615076055.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20191204023642.GD7328@magnolia>
Hi,
----- Original Message -----
> From: "Darrick J. Wong" <darrick.wong@oracle.com>
> To: "Eryu Guan" <guaneryu@gmail.com>
> Cc: "Yang Xu" <xuyang2018.ky@cn.fujitsu.com>, "fstests" <fstests@vger.kernel.org>, "xfs" <linux-xfs@vger.kernel.org>
> Sent: Wednesday, December 4, 2019 10:36:42 AM
> Subject: [PATCH] xfs/148: sort attribute list output
>
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Yang Xu reported a test failure in xfs/148 that I think comes from
> extended attributes being returned in a different order than they were
> set. Since order isn't important in this test, sort the output to make
> it consistent.
>
> Reported-by: Yang Xu <xuyang2018.ky@cn.fujitsu.com>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> tests/xfs/148 | 2 +-
> tests/xfs/148.out | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/xfs/148 b/tests/xfs/148
> index 42cfdab0..ec1d0ece 100755
> --- a/tests/xfs/148
> +++ b/tests/xfs/148
> @@ -76,7 +76,7 @@ test_names+=("too_many" "are_bad/for_you")
>
> access_stuff() {
> ls $testdir
> - $ATTR_PROG -l $testfile
> + $ATTR_PROG -l $testfile | grep 'a_' | sort
>
> for name in "${test_names[@]}"; do
> ls "$testdir/f_$name"
> diff --git a/tests/xfs/148.out b/tests/xfs/148.out
> index c301ecb6..f95b55b7 100644
> --- a/tests/xfs/148.out
> +++ b/tests/xfs/148.out
> @@ -4,10 +4,10 @@ f_another
> f_are_bad_for_you
> f_something
> f_too_many_beans
> +Attribute "a_another" has a 3 byte value for TEST_DIR/mount-148/testfile
> +Attribute "a_are_bad_for_you" has a 3 byte value for
From my test on RHEL8&RHEL7, when touch a file, there is a default attribute:
Attribute "selinux" has a 37 byte value for TEST_DIR/mount-148/testfile
Could you share the OS you test?
Thanks.
> TEST_DIR/mount-148/testfile
> Attribute "a_something" has a 3 byte value for TEST_DIR/mount-148/testfile
> Attribute "a_too_many_beans" has a 3 byte value for
> TEST_DIR/mount-148/testfile
> -Attribute "a_are_bad_for_you" has a 3 byte value for
> TEST_DIR/mount-148/testfile
> -Attribute "a_another" has a 3 byte value for TEST_DIR/mount-148/testfile
> TEST_DIR/mount-148/testdir/f_something
> Attribute "a_something" had a 3 byte value for TEST_DIR/mount-148/testfile:
> heh
>
>
next prev parent reply other threads:[~2019-12-06 6:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 2:36 [PATCH] xfs/148: sort attribute list output Darrick J. Wong
2019-12-06 6:51 ` Xiaoli Feng [this message]
2019-12-06 7:08 ` Yang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=443856653.20019671.1575615076055.JavaMail.zimbra@redhat.com \
--to=xifeng@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
--cc=xuyang2018.ky@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).