From: Xiubo Li <xiubli@redhat.com>
To: Zorro Lang <zlang@redhat.com>
Cc: fstests@vger.kernel.org, david@fromorbit.com, djwong@kernel.org,
ceph-devel@vger.kernel.org, vshankar@redhat.com
Subject: Re: [PATCH] generic/075: no need to move the .fsxlog to the same directory
Date: Wed, 22 Mar 2023 10:24:36 +0800 [thread overview]
Message-ID: <829cd072-271b-b22a-4ab3-74a786d41e58@redhat.com> (raw)
In-Reply-To: <20230320143703.dv5ab4tnwrs5cnwl@zlang-mailbox>
On 20/03/2023 22:37, Zorro Lang wrote:
> On Wed, Mar 01, 2023 at 10:07:30AM +0800, xiubli@redhat.com wrote:
>> From: Xiubo Li <xiubli@redhat.com>
>>
>> Actually it was trying to move the '075.$_n.fsxlog' from results
>> directory to the same results directory.
>>
>> Fixes: https://tracker.ceph.com/issues/58834
>> Signed-off-by: Xiubo Li <xiubli@redhat.com>
>> ---
>> tests/generic/075 | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/tests/generic/075 b/tests/generic/075
>> index 9f24ad41..03a394a6 100755
>> --- a/tests/generic/075
>> +++ b/tests/generic/075
>> @@ -57,7 +57,6 @@ _do_test()
>> then
>> echo " fsx ($_param) failed, $? - compare $seqres.$_n.{good,bad,fsxlog}"
>> mv $out/$seq.$_n $seqres.$_n.full
>> - mv "$RESULT_DIR"/$seq.$_n.fsxlog $seqres.$_n.fsxlog
> Hmm... Thoese $seq, $seqnum, $seqres, $RESULT_DIR and $REPORT_DIR are mess for
> me too :-D
>
> From the logic of xfstests/check:
>
> if $OPTIONS_HAVE_SECTIONS; then
> export RESULT_DIR=`echo $group | sed -e "s;$SRC_DIR;${RESULT_BASE}/$section;"`
> REPORT_DIR="$RESULT_BASE/$section"
> else
> export RESULT_DIR=`echo $group | sed -e "s;$SRC_DIR;$RESULT_BASE;"`
> REPORT_DIR="$RESULT_BASE"
> fi
> seqres="$REPORT_DIR/$seqnum"
>
>
> I think "$RESULT_DIR"/$seq equal to "$seqres", so this change makes sense to me.
> (Not sure if there're some special situations which I don't know :)
>
> The generic/075 is too old, lots of code in it can be removed or refactored, so
> I think it's not worth changing it bit by bit, I can refactor it totally, or if
> you'd like, you can do that.
Yeah, I can do that later, but not recently.
I may add some more tests in future and then I can improve this together.
Thanks Zorro,
- Xiubo
> Thanks,
> Zorro
>
>> od -xAx $seqres.$_n.full > $seqres.$_n.bad
>> od -xAx "$RESULT_DIR"/$seq.$_n.fsxgood > $seqres.$_n.good
>> rm -f "$RESULT_DIR"/$seq.$_n.fsxgood
>> --
>> 2.31.1
>>
--
Best Regards,
Xiubo Li (李秀波)
Email: xiubli@redhat.com/xiubli@ibm.com
Slack: @Xiubo Li
prev parent reply other threads:[~2023-03-22 2:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 2:07 [PATCH] generic/075: no need to move the .fsxlog to the same directory xiubli
2023-03-19 6:31 ` Xiubo Li
2023-03-20 14:37 ` Zorro Lang
2023-03-22 2:24 ` Xiubo Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=829cd072-271b-b22a-4ab3-74a786d41e58@redhat.com \
--to=xiubli@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=vshankar@redhat.com \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).