* [PATCH] tests/ceph: add Makefile
@ 2020-11-01 17:16 Eric Biggers
2020-11-01 18:28 ` Luis Henriques
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Eric Biggers @ 2020-11-01 17:16 UTC (permalink / raw)
To: fstests; +Cc: Luis Henriques
From: Eric Biggers <ebiggers@google.com>
'make install' stopped working because the tests/ceph/ directory is
missing a Makefile. Add it.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
tests/ceph/Makefile | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
create mode 100644 tests/ceph/Makefile
diff --git a/tests/ceph/Makefile b/tests/ceph/Makefile
new file mode 100644
index 00000000..55e35d77
--- /dev/null
+++ b/tests/ceph/Makefile
@@ -0,0 +1,18 @@
+# SPDX-License-Identifier: GPL-2.0
+
+TOPDIR = ../..
+include $(TOPDIR)/include/builddefs
+
+CEPH_DIR = ceph
+TARGET_DIR = $(PKG_LIB_DIR)/$(TESTS_DIR)/$(CEPH_DIR)
+
+include $(BUILDRULES)
+
+install:
+ $(INSTALL) -m 755 -d $(TARGET_DIR)
+ $(INSTALL) -m 755 $(TESTS) $(TARGET_DIR)
+ $(INSTALL) -m 644 group $(TARGET_DIR)
+ $(INSTALL) -m 644 $(OUTFILES) $(TARGET_DIR)
+
+# Nothing.
+install-dev install-lib:
--
2.29.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] tests/ceph: add Makefile
2020-11-01 17:16 [PATCH] tests/ceph: add Makefile Eric Biggers
@ 2020-11-01 18:28 ` Luis Henriques
2020-11-02 20:25 ` Bill O'Donnell
2020-11-03 11:27 ` Vladimir Zapolskiy
2 siblings, 0 replies; 4+ messages in thread
From: Luis Henriques @ 2020-11-01 18:28 UTC (permalink / raw)
To: Eric Biggers; +Cc: fstests
Eric Biggers <ebiggers@kernel.org> writes:
> From: Eric Biggers <ebiggers@google.com>
>
> 'make install' stopped working because the tests/ceph/ directory is
> missing a Makefile. Add it.
Yikes! Sorry about that. Thanks for fixing this, Eric.
Cheers,
--
Luis
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
> tests/ceph/Makefile | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
> create mode 100644 tests/ceph/Makefile
>
> diff --git a/tests/ceph/Makefile b/tests/ceph/Makefile
> new file mode 100644
> index 00000000..55e35d77
> --- /dev/null
> +++ b/tests/ceph/Makefile
> @@ -0,0 +1,18 @@
> +# SPDX-License-Identifier: GPL-2.0
> +
> +TOPDIR = ../..
> +include $(TOPDIR)/include/builddefs
> +
> +CEPH_DIR = ceph
> +TARGET_DIR = $(PKG_LIB_DIR)/$(TESTS_DIR)/$(CEPH_DIR)
> +
> +include $(BUILDRULES)
> +
> +install:
> + $(INSTALL) -m 755 -d $(TARGET_DIR)
> + $(INSTALL) -m 755 $(TESTS) $(TARGET_DIR)
> + $(INSTALL) -m 644 group $(TARGET_DIR)
> + $(INSTALL) -m 644 $(OUTFILES) $(TARGET_DIR)
> +
> +# Nothing.
> +install-dev install-lib:
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tests/ceph: add Makefile
2020-11-01 17:16 [PATCH] tests/ceph: add Makefile Eric Biggers
2020-11-01 18:28 ` Luis Henriques
@ 2020-11-02 20:25 ` Bill O'Donnell
2020-11-03 11:27 ` Vladimir Zapolskiy
2 siblings, 0 replies; 4+ messages in thread
From: Bill O'Donnell @ 2020-11-02 20:25 UTC (permalink / raw)
To: Eric Biggers; +Cc: fstests, Luis Henriques
On Sun, Nov 01, 2020 at 09:16:19AM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> 'make install' stopped working because the tests/ceph/ directory is
> missing a Makefile. Add it.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
thanks-
Reviewed-by: Bill O'Donnell <billodo@redhat.com>
> ---
> tests/ceph/Makefile | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
> create mode 100644 tests/ceph/Makefile
>
> diff --git a/tests/ceph/Makefile b/tests/ceph/Makefile
> new file mode 100644
> index 00000000..55e35d77
> --- /dev/null
> +++ b/tests/ceph/Makefile
> @@ -0,0 +1,18 @@
> +# SPDX-License-Identifier: GPL-2.0
> +
> +TOPDIR = ../..
> +include $(TOPDIR)/include/builddefs
> +
> +CEPH_DIR = ceph
> +TARGET_DIR = $(PKG_LIB_DIR)/$(TESTS_DIR)/$(CEPH_DIR)
> +
> +include $(BUILDRULES)
> +
> +install:
> + $(INSTALL) -m 755 -d $(TARGET_DIR)
> + $(INSTALL) -m 755 $(TESTS) $(TARGET_DIR)
> + $(INSTALL) -m 644 group $(TARGET_DIR)
> + $(INSTALL) -m 644 $(OUTFILES) $(TARGET_DIR)
> +
> +# Nothing.
> +install-dev install-lib:
> --
> 2.29.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tests/ceph: add Makefile
2020-11-01 17:16 [PATCH] tests/ceph: add Makefile Eric Biggers
2020-11-01 18:28 ` Luis Henriques
2020-11-02 20:25 ` Bill O'Donnell
@ 2020-11-03 11:27 ` Vladimir Zapolskiy
2 siblings, 0 replies; 4+ messages in thread
From: Vladimir Zapolskiy @ 2020-11-03 11:27 UTC (permalink / raw)
To: Eric Biggers, fstests; +Cc: Luis Henriques
On 11/1/20 7:16 PM, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> 'make install' stopped working because the tests/ceph/ directory is
> missing a Makefile. Add it.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Thank you for the fix.
Reviewed-by: Vladimir Zapolskiy <vladimir@tuxera.com>
Tested-by: Vladimir Zapolskiy <vladimir@tuxera.com>
--
Best wishes,
Vladimir
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-03 11:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-01 17:16 [PATCH] tests/ceph: add Makefile Eric Biggers
2020-11-01 18:28 ` Luis Henriques
2020-11-02 20:25 ` Bill O'Donnell
2020-11-03 11:27 ` Vladimir Zapolskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).