From: Amir Goldstein <email@example.com> To: "Darrick J. Wong" <firstname.lastname@example.org> Cc: Eryu Guan <email@example.com>, linux-xfs <firstname.lastname@example.org>, fstests <email@example.com>, Deepa Dinamani <firstname.lastname@example.org> Subject: Re: [PATCH 4/4] xfs: test upgrading filesystem to bigtime Date: Tue, 18 Aug 2020 21:40:26 +0300 Message-ID: <CAOQ4uxgzMD_Zi90OwYiv2PH7rRs+W7MSYU3Zf0KVG1Kw-rQ-KA@mail.gmail.com> (raw) In-Reply-To: <20200818182322.GX6096@magnolia> > > Darrick, > > > > These tests look great, but I wonder. > > generic/402 has more test coverage than above. > > It tests several data points and it tests them with and without mount cycle. > > Um... these two tests exist to make sure that /upgrading/ works, whereas > generic/402 tests whatever it finds on the formatted scratch filesystem. > > > With your current tests, bigtime will enjoy this test coverage only if > > the entire > > run is configured with custom XFS_MKFS_OPTIONS or when bigtime > > becomes default for mkfs. > > I don't understand the line of reasoning. Both tests format with > specific mkfs options, or skip the test entirely if mkfs doesn't know > what bigtime is. > I was referring to generic/402. > > Do you think we should have a temporary clone of generic/402 for xfs which > > enables bigtime for the time being? > > <shrug> I pushed most of my testing to the cloud, so I just spawn enough > VMs so that one of them will test bigtime=0 and another does > bigtime=1... > Fine by me. As long as there is test coverage for generic/402 with bigtime. Thanks, Amir.
next prev parent reply index Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-17 23:00 [PATCH RFC 0/4] xfstests: widen timestamps to deal with y2038 Darrick J. Wong 2020-08-17 23:01 ` [PATCH 1/4] xfs/122: embiggen struct xfs_agi size for inobtcount feature Darrick J. Wong 2020-08-17 23:01 ` [PATCH 2/4] xfs: test inobtcount upgrade Darrick J. Wong 2020-08-17 23:01 ` [PATCH 3/4] xfs: detect time limits from filesystem Darrick J. Wong 2020-08-17 23:01 ` [PATCH 4/4] xfs: test upgrading filesystem to bigtime Darrick J. Wong 2020-08-18 6:16 ` Amir Goldstein 2020-08-18 18:23 ` Darrick J. Wong 2020-08-18 18:40 ` Amir Goldstein [this message] 2020-10-27 19:03 [PATCH RFC v6 0/4] xfstests: widen timestamps to deal with y2038+ Darrick J. Wong 2020-10-27 19:04 ` [PATCH 4/4] xfs: test upgrading filesystem to bigtime Darrick J. Wong 2020-10-29 13:06 ` Amir Goldstein 2020-10-29 18:22 ` Darrick J. Wong 2021-03-31 1:08 [PATCHSET 0/4] fstests: widen timestamps to deal with y2038+ Darrick J. Wong 2021-03-31 1:08 ` [PATCH 4/4] xfs: test upgrading filesystem to bigtime Darrick J. Wong 2021-03-31 9:49 ` Amir Goldstein 2021-03-31 15:56 ` Darrick J. Wong 2021-04-11 13:40 ` Eryu Guan 2021-04-12 17:43 ` Darrick J. Wong 2021-04-21 0:23 [PATCHSET v4 0/4] fstests: widen timestamps to deal with y2038+ Darrick J. Wong 2021-04-21 0:23 ` [PATCH 4/4] xfs: test upgrading filesystem to bigtime Darrick J. Wong 2021-04-21 6:18 ` Amir Goldstein 2021-04-21 16:41 ` Darrick J. Wong 2021-04-22 21:16 ` Allison Henderson 2021-04-25 7:21 ` Eryu Guan 2021-04-25 15:42 ` Darrick J. Wong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAOQ4uxgzMD_Zi90OwYiv2PH7rRs+W7MSYU3Zf0KVG1Kw-rQ-KA@mail.gmail.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
FSTests Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/fstests/0 fstests/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 fstests fstests/ https://lore.kernel.org/fstests \ email@example.com public-inbox-index fstests Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.fstests AGPL code for this site: git clone https://public-inbox.org/public-inbox.git