fstests.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Brian Foster <bfoster@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	fstests <fstests@vger.kernel.org>,
	linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH v2] generic: disable dmlogwrites tests on XFS
Date: Tue, 1 Sep 2020 17:04:53 +0300	[thread overview]
Message-ID: <CAOQ4uxi=OD5Pk3c44AFhyH9fv=76U=ygj5+_rAuFgks_Eu2jtw@mail.gmail.com> (raw)
In-Reply-To: <20200901123130.GA174813@bfoster>

> I don't see much difference with zero/punch on dm-thinp. An
> fallocate(FL_PUNCH_HOLE|FL_KEEP_SIZE) doesn't work because it explicitly
> requests hardware zeroing, which I don't have.
> fallocate(FL_ZERO_RANGE|FL_KEEP_SIZE) works, but takes a minute or two
> on my 10G device because it falls back to manual zeroing. There is a
> NO_HIDE_STALE variant of PUNCH_HOLE, but I don't seem to have any
> userspace tools that define NO_HIDE_STALE and it looks like it just
> sends discards anyways. Of course, a 'blkdiscard -o 0 -l 10g <thindev>'
> unmaps nearly the entire device in ~1s, but then we're back to the
> argument of using discard for zeroing. :P
>

I don't think that is a problem if we build the test around thinp and its
well defined behavior on discard. This is what I was getting at:
1. Move dm-thinp setup inside the dm-logwrite helpers, so dm-logwrites
    tests cannot be written without dm-thinp by mistake.
2. Use explicit discard in start of replay helper to zap everything before
    replay

I'll add to my TODO list.

Thanks,
Amir.

      reply	other threads:[~2020-09-01 14:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-27 14:53 [PATCH v2] generic: disable dmlogwrites tests on XFS Brian Foster
2020-08-29  6:48 ` Christoph Hellwig
2020-08-31 13:37   ` Brian Foster
2020-08-31 16:02     ` Christoph Hellwig
2020-09-01  6:25     ` Amir Goldstein
2020-09-01 12:31       ` Brian Foster
2020-09-01 14:04         ` Amir Goldstein [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOQ4uxi=OD5Pk3c44AFhyH9fv=76U=ygj5+_rAuFgks_Eu2jtw@mail.gmail.com' \
    --to=amir73il@gmail.com \
    --cc=bfoster@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=hch@infradead.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).