fstests.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Chengguang Xu <cgxu519@mykernel.net>
Cc: fstests <fstests@vger.kernel.org>,
	overlayfs <linux-unionfs@vger.kernel.org>,
	Eryu Guan <guaneryu@gmail.com>,
	Miklos Szeredi <miklos@szeredi.hu>
Subject: Re: [PATCH] overlay/066: adjust test file size && add more test patterns
Date: Tue, 29 Oct 2019 14:32:43 +0200	[thread overview]
Message-ID: <CAOQ4uxiZgmA6Z8Lq=ac7O9f1+CMnSmyLoAA7TDu6Hyt=-pUctw@mail.gmail.com> (raw)
In-Reply-To: <CAOQ4uxjddbot29=cYqLMLyqT=w=pWmLOPqVzvi-5mcXQ3AB3EQ@mail.gmail.com>

On Tue, Oct 29, 2019 at 1:58 PM Amir Goldstein <amir73il@gmail.com> wrote:
>
> On Tue, Oct 29, 2019 at 1:17 PM Chengguang Xu <cgxu519@mykernel.net> wrote:
> >
> >  ---- 在 星期二, 2019-10-29 16:32:32 Amir Goldstein <amir73il@gmail.com> 撰写 ----
> >  > On Tue, Oct 29, 2019 at 7:57 AM Chengguang Xu <cgxu519@mykernel.net> wrote:
> >  > >
> >  >
> >  > Can you please send the patch as plain/text.
> >  > Your mailer has sent it with quoted printable encoding and git am
> >  > fails to apply the patch:
> >  > https://lore.kernel.org/fstests/20191029055713.28191-1-cgxu519@mykernel.net/raw
> >  >
> >
> > Sorry for that,  I'm not clear for the reason, so I send you the patch in attachment first.
> >
>

OK, I can verify that test runs quick (5s) on my VM.

But there is one more issue that I think needs to be addressed, either
in this fix patch or in a follow up patch.

If the test ever fails on some run with a specific random holes sequence,
it is going to be quite hard for reporter to report this sequence or for
developers to reproduce the same random sequence.

One way to fix this is to output the sequence of commands that
generated the random files to full output, so it can be used as a recipe
for reproducer in case of a failure.

If you do that, please make sure that the recipe for creating
small random file is clearly separated from recipe for creating
big random file.

Thanks,
Amir.

  reply	other threads:[~2019-10-29 12:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-29  5:57 [PATCH] overlay/066: adjust test file size && add more test patterns Chengguang Xu
2019-10-29  8:32 ` Amir Goldstein
2019-10-29 11:17   ` Chengguang Xu
2019-10-29 11:58     ` Amir Goldstein
2019-10-29 12:32       ` Amir Goldstein [this message]
2019-10-30  4:46         ` Chengguang Xu
2019-10-30  5:33           ` Amir Goldstein
2019-11-05  6:00             ` Chengguang Xu
2019-11-05  7:37               ` Amir Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOQ4uxiZgmA6Z8Lq=ac7O9f1+CMnSmyLoAA7TDu6Hyt=-pUctw@mail.gmail.com' \
    --to=amir73il@gmail.com \
    --cc=cgxu519@mykernel.net \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).