fstests.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Christian Brauner <christian.brauner@ubuntu.com>
Cc: Christian Brauner <brauner@kernel.org>, Eryu Guan <guan@eryu.me>,
	fstests <fstests@vger.kernel.org>, Christoph Hellwig <hch@lst.de>,
	"Darrick J . Wong" <djwong@kernel.org>,
	David Howells <dhowells@redhat.com>
Subject: Re: [PATCH v10 1/6] generic/631: add test for detached mount propagation
Date: Wed, 24 Mar 2021 10:04:39 +0200	[thread overview]
Message-ID: <CAOQ4uxj=i=ppYtru0445Hzr74m6JZ_Z1gUoLoVjJnNsQiDi4fw@mail.gmail.com> (raw)
In-Reply-To: <20210324075002.suuey4me7b4faruo@wittgenstein>

On Wed, Mar 24, 2021 at 9:50 AM Christian Brauner
<christian.brauner@ubuntu.com> wrote:
>
> On Wed, Mar 24, 2021 at 09:40:50AM +0200, Amir Goldstein wrote:
> > On Mon, Mar 22, 2021 at 3:46 PM Christian Brauner <brauner@kernel.org> wrote:
> > >
> > > From: Christian Brauner <christian.brauner@ubuntu.com>
> > >
> > > Regression test to verify that creating a series of detached mounts,
> > > attaching them to the filesystem, and unmounting them does not trigger an
> > > integer overflow in ns->mounts causing the kernel to block any new mounts in
> > > count_mounts() and returning ENOSPC because it falsely assumes that the
> > > maximum number of mounts in the mount namespace has been reached, i.e. it
> > > thinks it can't fit the new mounts into the mount namespace anymore.
> > >
> > > The test is written in a way that it will leave the host's mount
> > > namespace intact so we are sure to never make the host's mount namespace
> > > unuseable!
> > >
> > > Link: https://git.kernel.org/torvalds/c/ee2e3f50629f17b0752b55b2566c15ce8dafb557
> > > Cc: Eryu Guan <guan@eryu.me>
> > > Cc: David Howells <dhowells@redhat.com>
> > > Reviewed-by: Christoph Hellwig <hch@lst.de>
> > > Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
> > > ---
> > > /* v1 - v8 */
> > > patch not present
> > >
> > > /* v9 */
> > > - Christian Brauner <christian.brauner@ubuntu.com>:
> > >   - Rebased on current master.
> > >
> > > /* v10 */
> > > - Eryu Guan <guan@eryu.me>:
> > >   - Add missing checks whether test is supported.
> > >   - Move status=$? assignment up.
> > > ---
> >
> > Technical nit: why did you add this extra --- line?
> > It causes all the patch changelog to appear in the commit message.
> > I don't think that was your intention? and I don't think it adds valuable
> > into to git log.
>
> I've not done that in any of the other patches or on any other patches I
> ever wrote so I think this was just a copy-paste error when I updated
> the changelog.
>

Please note this glitch happened in all the patches in the series...

Thanks,
Amir.

  reply	other threads:[~2021-03-24  8:05 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-22 13:45 [PATCH v10 0/6] fstests: add idmapped mounts tests Christian Brauner
2021-03-22 13:45 ` [PATCH v10 1/6] generic/631: add test for detached mount propagation Christian Brauner
2021-03-24  7:40   ` Amir Goldstein
2021-03-24  7:50     ` Christian Brauner
2021-03-24  8:04       ` Amir Goldstein [this message]
2021-03-24  8:39         ` Christian Brauner
2021-03-24  9:45           ` Amir Goldstein
2021-03-24  9:52             ` Christian Brauner
2021-03-22 13:45 ` [PATCH v10 3/6] common/rc: add _scratch_{u}mount_idmapped() helpers Christian Brauner
2021-03-22 13:45 ` [PATCH v10 4/6] common/quota: move _qsetup() helper to common code Christian Brauner
2021-03-22 13:45 ` [PATCH v10 5/6] xfs/529: quotas and idmapped mounts Christian Brauner
2021-03-22 13:45 ` [PATCH v10 6/6] xfs/530: quotas on " Christian Brauner
2021-03-22 13:50 ` [PATCH v10 0/6] fstests: add idmapped mounts tests Christian Brauner
2021-03-22 14:21   ` Christian Brauner
2021-03-24  8:03     ` Amir Goldstein
2021-03-24  8:41       ` Christian Brauner
2021-03-24 11:24         ` Amir Goldstein
2021-03-24 13:33           ` Amir Goldstein
2021-03-24 13:49             ` Christian Brauner
2021-03-24 13:45           ` Christian Brauner
2021-03-24 14:01             ` Amir Goldstein
2021-03-24 14:03               ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOQ4uxj=i=ppYtru0445Hzr74m6JZ_Z1gUoLoVjJnNsQiDi4fw@mail.gmail.com' \
    --to=amir73il@gmail.com \
    --cc=brauner@kernel.org \
    --cc=christian.brauner@ubuntu.com \
    --cc=dhowells@redhat.com \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=guan@eryu.me \
    --cc=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).