FSTests Archive on lore.kernel.org
 help / color / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Chengguang Xu <cgxu519@mykernel.net>
Cc: fstests <fstests@vger.kernel.org>,
	overlayfs <linux-unionfs@vger.kernel.org>,
	Eryu Guan <guaneryu@gmail.com>,
	Miklos Szeredi <miklos@szeredi.hu>
Subject: Re: [PATCH v3] overlay/066: adjust test file size && add more test patterns
Date: Wed, 6 Nov 2019 13:26:07 +0200
Message-ID: <CAOQ4uxjWjjMw7o32JaG_nuqw4oXw_Qo+jWjhRXkQ9pd9o1QjmQ@mail.gmail.com> (raw)
In-Reply-To: <16e403ebe86.e4a465d3522.6312283139717764767@mykernel.net>

On Wed, Nov 6, 2019 at 12:24 PM Chengguang Xu <cgxu519@mykernel.net> wrote:
>
>  ---- 在 星期三, 2019-11-06 18:01:54 Amir Goldstein <amir73il@gmail.com> 撰写 ----
>  > On Wed, Nov 6, 2019 at 9:40 AM Chengguang Xu <cgxu519@mykernel.net> wrote:
>  > >
>  > > Making many small holes in 10M test file seems not very
>  > > helpful for test coverage and it takes too much time on
>  > > creating test files. In order to improve test speed we
>  > > adjust test file size to (10 * iosize) for iosize aligned
>  > > hole files and meanwhile add more test patterns for small
>  > > random holes and small empty file.
>  > >
>  > > Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
>  > Reviewed-by: Amir Goldstein <amir73il@gmail.com>
>  >
>  > Please send me a plain text version of the patch so I can test it.
>  >
>
> Hi Amir,
>
> Sorry for that again but I really don't know what was wrong for this patch.
> I sent using 'git send-email' and there was nothing broken or unusual compare
> to other normal patches. So I have to send this patch in attachment again.
>

Test runs fine, except big random file has a single chunk 32MB of data:

Big random hole test write scenarios ---

/root/xfstests/bin/xfs_io -i -fc "pwrite 1024K 30862K"
/vdf/ovl-lower/copyup_sparse_test_random_big
wrote 31602688/31602688 bytes at offset 1048576
30 MiB, 7716 ops; 0.1295 sec (232.614 MiB/sec and 59553.1201 ops/sec)

That is because of this typo:

@@ -133,7 +133,7 @@ file_size=102400
 min_hole=1024
 max_hole=5120
 pos=$min_hole
-max_hole=$(($file_size - 2*$max_hole))
+max_pos=$(($file_size - 2*$max_hole))

If you re-submit, please add my Reviewed-by tag.

Thanks,
Amir.

  reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-06  7:39 Chengguang Xu
2019-11-06 10:01 ` Amir Goldstein
2019-11-06 10:24   ` Chengguang Xu
2019-11-06 11:26     ` Amir Goldstein [this message]
2019-11-06 11:43       ` Chengguang Xu

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOQ4uxjWjjMw7o32JaG_nuqw4oXw_Qo+jWjhRXkQ9pd9o1QjmQ@mail.gmail.com \
    --to=amir73il@gmail.com \
    --cc=cgxu519@mykernel.net \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

FSTests Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/fstests/0 fstests/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 fstests fstests/ https://lore.kernel.org/fstests \
		fstests@vger.kernel.org
	public-inbox-index fstests

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.fstests


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git