From: Eric Biggers <ebiggers@kernel.org>
To: Theodore Ts'o <tytso@mit.edu>
Cc: fstests@vger.kernel.org
Subject: Re: [xfstests-bld PATCH] gen-tarball: add 'set -e'
Date: Wed, 11 Nov 2020 13:25:10 -0800 [thread overview]
Message-ID: <X6xWtkUQeUGcE786@sol.localdomain> (raw)
In-Reply-To: <20201111192152.GA335825@gmail.com>
On Wed, Nov 11, 2020 at 11:21:52AM -0800, Eric Biggers wrote:
> On Sun, Nov 01, 2020 at 09:24:50AM -0800, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@google.com>
> >
> > The latest master branch of xfstests is missing a Makefile in
> > tests/ceph/, which broke xfstests's 'make install'. But gen-tarball
> > didn't notice this. Fix this by adding 'set -e', and to make this work
> > adjust a couple other commands that are expected to fail.
> >
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
> > ---
> > gen-tarball | 12 +++++++++---
> > 1 file changed, 9 insertions(+), 3 deletions(-)
> >
>
> Ping. Ted, are you planning to apply this? The master branch of xfstests is
> fixed now, but this gen-tarball change would still be good to have.
>
Actually, I missed one case where a failure is expected -- the case where
kvm-xfstests/test-appliance/debs doesn't exist. I'll send v2.
- Eric
next prev parent reply other threads:[~2020-11-11 21:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-01 17:24 [xfstests-bld PATCH] gen-tarball: add 'set -e' Eric Biggers
2020-11-11 19:21 ` Eric Biggers
2020-11-11 21:25 ` Eric Biggers [this message]
2020-11-11 21:35 ` [xfstests-bld PATCH v2] " Eric Biggers
2020-11-12 3:51 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X6xWtkUQeUGcE786@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).