From: Eryu Guan <guan@eryu.me>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Zorro Lang <zlang@redhat.com>, fstests@vger.kernel.org
Subject: Re: [PATCH] xfs: quota state command should report upg grace times separately
Date: Sun, 8 Aug 2021 22:11:59 +0800 [thread overview]
Message-ID: <YQ/mL8E6GKMSPdWd@desktop> (raw)
In-Reply-To: <20210806185910.GF3601425@magnolia>
On Fri, Aug 06, 2021 at 11:59:10AM -0700, Darrick J. Wong wrote:
> On Fri, Aug 06, 2021 at 01:10:12PM +0800, Zorro Lang wrote:
> > Regression test for d8a94546 ("xfs_quota: state command should report
> > ugp grace times"). When give "-ugp" or "-a" options to xfs_quota
> > state command, it should report grace times for all three types
> > separately.
> >
> > Signed-off-by: Zorro Lang <zlang@redhat.com>
> > ---
> > tests/xfs/175 | 33 +++++++++++++++++++++++++++++++++
> > tests/xfs/175.out | 21 +++++++++++++++++++++
> > 2 files changed, 54 insertions(+)
> > create mode 100755 tests/xfs/175
> > create mode 100644 tests/xfs/175.out
> >
> > diff --git a/tests/xfs/175 b/tests/xfs/175
> > new file mode 100755
> > index 00000000..0b7d81ec
> > --- /dev/null
> > +++ b/tests/xfs/175
> > @@ -0,0 +1,33 @@
> > +#! /bin/bash
> > +# SPDX-License-Identifier: GPL-2.0
> > +# Copyright (c) 2021 Red Hat, Inc. All Rights Reserved.
> > +#
> > +# FS QA Test 175
> > +#
> > +# Regression test for d8a94546 ("xfs_quota: state command should report
>
> Might be worth saying explicitly that this is an xfsprogs commit.
I'll fix that on commit, Zorro, there's no need to resend.
>
> > +# ugp grace times"). When give "-ugp" or "-a" options to xfs_quota state
> > +# command, it should report grace times for all three types separately.
> > +#
> > +. ./common/preamble
> > +_begin_fstest auto quick quota
> > +
> > +# real QA test starts here
> > +_supported_fs xfs
> > +_require_scratch
> > +_require_quota
> > +
> > +# Format filesystem and set up quota limits
> > +_scratch_mkfs > $seqres.full
> > +_qmount_option "grpquota"
> > +_scratch_mount >> $seqres.full
> > +
> > +$XFS_QUOTA_PROG -x -c 'timer -u 5d' $SCRATCH_MNT
> > +# xfs_quota state -ugp or -a should report times for all three types separately.
> > +echo "* state -ugp:"
> > +$XFS_QUOTA_PROG -x -c 'state -ugp' $SCRATCH_MNT | grep 'grace time'
> > +echo "* state -a:"
> > +$XFS_QUOTA_PROG -x -c 'state -a' $SCRATCH_MNT | grep 'grace time'
>
> Logic looks fine to me.
>
> With the comment fixed,
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Thanks for review!
Eryu
>
> --D
>
> > +
> > +# success, all done
> > +status=0
> > +exit
> > diff --git a/tests/xfs/175.out b/tests/xfs/175.out
> > new file mode 100644
> > index 00000000..83247e21
> > --- /dev/null
> > +++ b/tests/xfs/175.out
> > @@ -0,0 +1,21 @@
> > +QA output created by 175
> > +* state -ugp:
> > +Blocks grace time: [--------]
> > +Inodes grace time: [--------]
> > +Realtime Blocks grace time: [--------]
> > +Blocks grace time: [5 days]
> > +Inodes grace time: [5 days]
> > +Realtime Blocks grace time: [5 days]
> > +Blocks grace time: [--------]
> > +Inodes grace time: [--------]
> > +Realtime Blocks grace time: [--------]
> > +* state -a:
> > +Blocks grace time: [--------]
> > +Inodes grace time: [--------]
> > +Realtime Blocks grace time: [--------]
> > +Blocks grace time: [5 days]
> > +Inodes grace time: [5 days]
> > +Realtime Blocks grace time: [5 days]
> > +Blocks grace time: [--------]
> > +Inodes grace time: [--------]
> > +Realtime Blocks grace time: [--------]
> > --
> > 2.31.1
> >
next prev parent reply other threads:[~2021-08-08 14:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 5:10 [PATCH] xfs: quota state command should report upg grace times separately Zorro Lang
2021-08-06 18:59 ` Darrick J. Wong
2021-08-08 14:11 ` Eryu Guan [this message]
2021-08-08 14:35 ` Eryu Guan
2021-08-08 15:44 ` Zorro Lang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YQ/mL8E6GKMSPdWd@desktop \
--to=guan@eryu.me \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).