From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A370AC4338F for ; Sun, 1 Aug 2021 12:53:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 75E8A610D2 for ; Sun, 1 Aug 2021 12:53:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231527AbhHAMxq (ORCPT ); Sun, 1 Aug 2021 08:53:46 -0400 Received: from out20-110.mail.aliyun.com ([115.124.20.110]:56935 "EHLO out20-110.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231461AbhHAMxq (ORCPT ); Sun, 1 Aug 2021 08:53:46 -0400 X-Alimail-AntiSpam: AC=CONTINUE;BC=0.07937175|-1;CH=green;DM=|CONTINUE|false|;DS=CONTINUE|ham_regular_dialog|0.0220319-0.00110911-0.976859;FP=0|0|0|0|0|-1|-1|-1;HT=ay29a033018047201;MF=guan@eryu.me;NM=1;PH=DS;RN=3;RT=3;SR=0;TI=SMTPD_---.KtqKEhT_1627822416; Received: from localhost(mailfrom:guan@eryu.me fp:SMTPD_---.KtqKEhT_1627822416) by smtp.aliyun-inc.com(10.147.41.137); Sun, 01 Aug 2021 20:53:36 +0800 Date: Sun, 1 Aug 2021 20:53:36 +0800 From: Eryu Guan To: Josef Bacik Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org Subject: Re: [PATCH] fstests: generic/204: fail if the mkfs fails Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org On Sun, Aug 01, 2021 at 08:42:02PM +0800, Eryu Guan wrote: > On Thu, Jul 29, 2021 at 04:35:53PM -0400, Josef Bacik wrote: > > My nightly fstests runs on my Raspberry Pi got stuck trying to run > > generic/204. This boiled down to mkfs failing to make the scratch > > device that small with the subpage blocksize support, and thus trying to > > fill a 1tib drive with tiny files. On one hand I'd like to make > > So the underlying disk is 1TB in size, and we ended up using this 1T > filesystem when _scratch_mkfs_sized failed? > > But we have done _try_wipe_scratch_devs before each test to make sure we > don't use previous scratch dev accidently (just like this case), and the > subsesquent _scratch_mount will fail and fail the whole test. So it's > not clear to me what caused the failure you hit. Ah, if the previous test _notrun'd, then the scratch dev didn't get wiped. I think patch "check: don't leave the scratch filesystem mounted after _notrun" from Darrick should fix the bug for you. Would you please confirm? Thanks, Eryu