fstests.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "yukuai (C)" <yukuai3@huawei.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: <guaneryu@gmail.com>, <jbacik@fusionio.com>,
	<fstests@vger.kernel.org>, <linux-xfs@vger.kernel.org>,
	<zhengbin13@huawei.com>, <yi.zhang@huawei.com>
Subject: Re: [PATCH] xfs/126: fix that corrupt xattr might fail with a small probability
Date: Fri, 17 Jan 2020 10:20:26 +0800	[thread overview]
Message-ID: <bc9afd0d-91e5-ef0a-94cb-599b8a57b136@huawei.com> (raw)
In-Reply-To: <20200116160323.GC2149943@magnolia>



On 2020/1/17 0:03, Darrick J. Wong wrote:
> Does adding "-o 4" to the blocktrash command make it work reliably?
> That should be close enough to the start of the attrleaf block that
> we'll reliably corrupt*some*  amount of stuff in the header.

Seems like a good idea!
After adding "-o 4", I tested over 200 times, and blocktrash never 
failed to corrupt xattr anymore.

Thanks!
Yu Kuai


  reply	other threads:[~2020-01-17  2:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-08  9:27 [PATCH] xfs/126: fix that corrupt xattr might fail with a small probability yu kuai
2020-01-08 16:22 ` Darrick J. Wong
2020-01-09  3:56   ` yukuai (C)
2020-01-09  4:00   ` yukuai (C)
2020-01-09 16:46     ` Darrick J. Wong
2020-01-16 12:22       ` yukuai (C)
2020-01-16 16:03         ` Darrick J. Wong
2020-01-17  2:20           ` yukuai (C) [this message]
2020-01-17  3:10             ` yukuai (C)
2020-01-17  6:15               ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc9afd0d-91e5-ef0a-94cb-599b8a57b136@huawei.com \
    --to=yukuai3@huawei.com \
    --cc=darrick.wong@oracle.com \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    --cc=jbacik@fusionio.com \
    --cc=linux-xfs@vger.kernel.org \
    --cc=yi.zhang@huawei.com \
    --cc=zhengbin13@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).