From: Nikolay Borisov <nborisov@suse.com>
To: Boris Burkov <boris@bur.io>,
fstests@vger.kernel.org, kernel-team@fb.com,
Eryu Guan <guaneryu@gmail.com>
Subject: Re: [PATCH] btrfs/220: fix clear_cache and inode_cache option tests
Date: Wed, 17 Feb 2021 13:29:47 +0200 [thread overview]
Message-ID: <d34daa78-9287-06c7-e3e8-25e76a7d3aba@suse.com> (raw)
In-Reply-To: <409e4c73fefce666d151b043d6b2a0d821f8ef85.1610485406.git.boris@bur.io>
On 12.01.21 г. 23:17 ч., Boris Burkov wrote:
> I recently changed clear_cache to not appear in mount options, as it has
> one shot semantics, which was breaking this test. Test explicitly that
> it _doesn't_ appear, which properly fails on old filesystems and passes
> on misc-next.
>
> The patch that changed this behavior was:
> 8b228324a8ce btrfs: clear free space tree on ro->rw remount
>
> Separately, inode_cache is deprecated and will never appear in mount
> options; remove it entirely.
>
> Signed-off-by: Boris Burkov
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Based on his previous patches to the kernel I guess this line should read:
Signed-off-by: Boris Burkov <boris@bur.io>
Eryu, would it be possible to merge this or should Boris resend?
> ---
> tests/btrfs/220 | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/tests/btrfs/220 b/tests/btrfs/220
> index c84c7065..1242460f 100755
> --- a/tests/btrfs/220
> +++ b/tests/btrfs/220
> @@ -215,11 +215,8 @@ test_optional_kernel_features()
>
> test_non_revertible_options()
> {
> - test_mount_opt "clear_cache" "clear_cache"
> test_mount_opt "degraded" "degraded"
>
> - test_mount_opt "inode_cache" "inode_cache"
> -
> # nologreplay should be used only with
> test_should_fail "nologreplay"
> test_mount_opt "nologreplay,ro" "ro,rescue=nologreplay"
> @@ -238,6 +235,11 @@ test_non_revertible_options()
> test_mount_opt "rescue=nologreplay,ro" "ro,rescue=nologreplay"
> }
>
> +test_one_shot_options()
> +{
> + test_mount_opt "clear_cache" ""
> +}
> +
> # All these options can be reverted (with their "no" counterpart), or can have
> # their values set to default on remount
> test_revertible_options()
> @@ -321,6 +323,8 @@ test_optional_kernel_features
>
> test_non_revertible_options
>
> +test_one_shot_options
> +
> test_revertible_options
>
> test_subvol
>
next prev parent reply other threads:[~2021-02-17 11:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 21:17 [PATCH] btrfs/220: fix clear_cache and inode_cache option tests Boris Burkov
2021-01-17 15:10 ` Eryu Guan
2021-02-17 11:29 ` Nikolay Borisov [this message]
2021-08-13 1:53 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d34daa78-9287-06c7-e3e8-25e76a7d3aba@suse.com \
--to=nborisov@suse.com \
--cc=boris@bur.io \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
--cc=kernel-team@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).