From: "Yang, Xiao/杨 晓" <yangx.jy@fujitsu.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: "zlang@redhat.com" <zlang@redhat.com>,
"fstests@vger.kernel.org" <fstests@vger.kernel.org>,
"bfoster@redhat.com" <bfoster@redhat.com>
Subject: Re: [PATCH RESEND 2/2] generic/470: Replace thin volume with blkdiscard -z
Date: Mon, 24 Oct 2022 15:15:56 +0800 [thread overview]
Message-ID: <ddc1978f-686e-de66-71bf-b39dbafc2a9d@fujitsu.com> (raw)
In-Reply-To: <Y1YP7ehSZUdVS4/J@magnolia>
On 2022/10/24 12:09, Darrick J. Wong wrote:
> On Sun, Oct 23, 2022 at 06:48:13AM +0000,yangx.jy@fujitsu.com wrote:
>> generic/470 was original designed to verify mmap(MAP_SYNC) which
>> is only vaild to the DAX capable device(e.g. PMEM). Thin volume[1] was
>> introduced to fix the inconsistent filesystem issue[2] but it make
>> the test become not run because it doesn't support DAX. As Darrick
>> mentioned[3], discarding the entire mapped range of scartch device
>> can fix the issue as well, so I try to use blkdiscard -z instead.
> That might be ok for the*other* dm-logwrites tests, but isn't the
> fundamental problem here (generic/470, specifically) that device mapper
> cannot run on top of pmem?
Hi Darrick,
With the change，I didn't find any failure when running generic/470 in
loops.
--------------------------------------------------------------
[root@fedora35 xfstests-dev]# ./check generic/470
FSTYP -- xfs (non-debug)
PLATFORM -- Linux/x86_64 fedora35 6.1.0-rc1+ #37 SMP
PREEMPT_DYNAMIC Fri Oct 21 19:04:57 CST 2022
MKFS_OPTIONS -- -f /dev/pmem0
MOUNT_OPTIONS -- -o context=system_u:object_r:root_t:s0 /dev/pmem0
/mnt/scratch
generic/470 6s
Ran: generic/470
Passed all 1 tests
--------------------------------------------------------------
Both dm-log-writes and PMEM support DAX so it's fine to verify
mmap(MAP_SYNC) with the dm-log-writes device on top of PMEM.
Did I miss something? Why do you think there is a fundamental problem here?
Best Regards,
Xiao Yang
>
> --D
>
next prev parent reply other threads:[~2022-10-24 7:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-23 6:48 [PATCH RESEND 1/2] common/dmlogwrites: Extend _log_writes_init() to accept the specified size yangx.jy
2022-10-23 6:48 ` [PATCH RESEND 2/2] generic/470: Replace thin volume with blkdiscard -z yangx.jy
2022-10-24 4:09 ` Darrick J. Wong
2022-10-24 7:15 ` Yang, Xiao/杨 晓 [this message]
2022-10-30 7:30 ` yangx.jy
2022-11-01 3:48 ` Darrick J. Wong
2022-11-12 5:48 ` Yang, Xiao/杨 晓
2022-11-13 17:57 ` Darrick J. Wong
2022-11-14 8:38 ` Yang, Xiao/杨 晓
2022-11-13 17:54 ` [PATCH RESEND 1/2] common/dmlogwrites: Extend _log_writes_init() to accept the specified size Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddc1978f-686e-de66-71bf-b39dbafc2a9d@fujitsu.com \
--to=yangx.jy@fujitsu.com \
--cc=bfoster@redhat.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).