From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90423C433ED for ; Mon, 26 Apr 2021 12:03:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4ABFC61178 for ; Mon, 26 Apr 2021 12:03:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231983AbhDZMEa (ORCPT ); Mon, 26 Apr 2021 08:04:30 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:43602 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231550AbhDZMEa (ORCPT ); Mon, 26 Apr 2021 08:04:30 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: shreeya) with ESMTPSA id 16C131F41F01 Subject: Re: [PATCH] generic/453: Exclude filenames that are not supported by exfat From: Shreeya Patel To: Matthew Wilcox Cc: fstests@vger.kernel.org, linux-fsdevel@vger.kernel.org, krisman@collabora.com, preichl@redhat.com, kernel@collabora.com References: <20210425223105.1855098-1-shreeya.patel@collabora.com> <20210426003430.GH235567@casper.infradead.org> Message-ID: Date: Mon, 26 Apr 2021 17:33:41 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org On 26/04/21 5:27 pm, Shreeya Patel wrote: > > On 26/04/21 6:04 am, Matthew Wilcox wrote: >> On Mon, Apr 26, 2021 at 04:01:05AM +0530, Shreeya Patel wrote: >>> exFAT filesystem does not support the following character codes >>> 0x0000 - 0x001F ( Control Codes ), /, ?, :, ", \, *, <, |, > >> ummm ... >> >>> -# Fake slash? >>> -setf "urk\xc0\xafmoo" "FAKESLASH" >> That doesn't use any of the explained banned characters.  It uses 0xc0, >> 0xaf. >> >> Now, in utf-8, that's an nonconforming sequence.  "The Unicode and UCS >> standards require that producers of UTF-8 shall use the shortest form >> possible, for example, producing a two-byte sequence with first byte >> 0xc0 >> is nonconforming.  Unicode 3.1 has added the requirement that conforming >> programs must not accept non-shortest forms in their input." >> >> So is it that exfat is rejecting nonconforming sequences?  Or is it >> converting the nonconforming sequence from 0xc0 0xaf to the conforming >> sequence 0x2f, and then rejecting it (because it's '/')? >> > > No, I don't think exfat is not converting nonconforming sequence from > 0xc0 0xaf > to the conforming sequence 0x2f. Sorry, I meant "I don't think exfat is converting nonconforming sequence from 0xc0 0xaf to the conforming sequence 0x2f." here. > Because I get different outputs when tried with both ways. > When I create a file with "urk\xc0\xafmoo", I get output as "Operation > not permitted" > and when I create it as "urk\x2fmoo", it gives "No such file or > directory error" or > you can consider this error as "Invalid argument" > ( because that's what I get when I try for other characters like |, :, > ?, etc ) > > Box filename also fails with "Invalid argument" error. > >