Re: [PATCH] sh: push-switch: Convert to platform remove callback returning void - Uwe Kleine-König

From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Yoshinori Sato <ysato@users.sourceforge.jp>,
	 Rich Felker <dalias@libc.org>,
	John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
	 Duoming Zhou <duoming@zju.edu.cn>,
	linux-sh@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] sh: push-switch: Convert to platform remove callback returning void
Date: Thu, 11 Apr 2024 09:18:30 +0200	[thread overview]
Message-ID: <fwfwlvyuznwzwejg3iqvnvgolxaqfo3aod5gbydgbwpj5l4xmr@y7fuszpv7kry> (raw)
In-Reply-To: <20240306211947.97103-2-u.kleine-koenig@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 1310 bytes --]

Hello,

[corrected the address of the Pengutronix kernel team in Cc:]

On Wed, Mar 06, 2024 at 10:19:47PM +0100, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> 
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.

Apart from Geert's positive review reply I didn't get any feedback on
this patch and it didn't appear in next yet.

As my quest to change the prototype of struct platform_driver::remove
depends on these patches, it would be great if they made it in during
the next merge window.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]