From: Brandon Casey <casey@nrlssc.navy.mil>
To: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: shell compatibility issues with SunOS 5.10
Date: Wed, 06 May 2009 13:14:07 -0500 [thread overview]
Message-ID: <-ElxRhvpfY_jx1Ps8nJ42rHdrKbR03T1y96WpGK19gM@cipher.nrlssc.navy.mil> (raw)
In-Reply-To: <20090506055913.GA9701@dektop>
Nguyen Thai Ngoc Duy wrote:
> Hi,
>
> I did "make test" on a SunOS 5.10 and it failed.
> diff --git a/t/t4200-rerere.sh b/t/t4200-rerere.sh
> index b68ab11..61ccdee 100755
> --- a/t/t4200-rerere.sh
> +++ b/t/t4200-rerere.sh
> @@ -57,7 +57,7 @@ test_expect_success 'conflicting merge' '
> test_must_fail git merge first
> '
>
> -sha1=$(sed -e 's/ .*//' .git/MERGE_RR)
> +sha1=$(cut -f 1 .git/MERGE_RR)
Are you using /bin/sed? I think it has a problem with tabs.
/usr/xpg4/bin/sed works correctly, but it has a problem with
files that are not newline terminated. So you will get other
errors. I have a set of "ugly" patches that I will follow this
email with that allow me to compile on Solaris 10 while skipping
the following tests:
GIT_SKIP_TESTS='
t3900.2[23]
t3901.[67]
t6030.1[23]
t8005.*
'
The t3900 and t3901 are due to iconv failures.
The t6030 issues are due to a flaw in Sun's ksh, i.e. /usr/xpg4/bin/sh
which I use for testing. This ksh seems to only call a trap that is
set within at most the next outer-layer function. In other words, if
func1 sets a trap, and calls func2 which calls func3 which exits, then
the trap in func1 will _not_ be called. If instead, func2 exits, then
the trap will be called. Bisect does such a thing. You should not
have a problem with other ksh or bash.
I had assumed t8005 was failing because of iconv, but since you have
pointed out the extended RE in grep, some of these should pass.
Converting to egrep allows tests 1, 4 and 5 to pass for me. So my skip
expression can be changed to t8005.[23].
> rr=.git/rr-cache/$sha1
> test_expect_success 'recorded preimage' "grep ^=======$ $rr/preimage"
Patches to follow.
-brandon
next prev parent reply other threads:[~2009-05-06 18:14 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-06 5:59 shell compatibility issues with SunOS 5.10 Nguyen Thai Ngoc Duy
2009-05-06 6:16 ` Junio C Hamano
2009-05-06 6:43 ` Nguyen Thai Ngoc Duy
2009-05-07 1:38 ` Nguyen Thai Ngoc Duy
2009-05-06 6:45 ` Johannes Sixt
2009-05-06 6:57 ` Nguyen Thai Ngoc Duy
2009-05-06 9:19 ` Ralf Wildenhues
2009-05-06 9:38 ` Johannes Schindelin
2009-05-06 23:07 ` Nguyen Thai Ngoc Duy
2009-05-06 13:07 ` Jeff King
2009-05-06 18:14 ` Brandon Casey [this message]
2009-05-06 18:29 ` [PATCH 0/4] workaround some Solaris sed issues Brandon Casey
2009-05-06 18:29 ` [PATCH 1/4] t4118: add missing '&&' Brandon Casey
2009-05-06 18:29 ` [PATCH 2/4] t4118: avoid sed invocation on file without terminating newline Brandon Casey
2009-05-06 18:29 ` [PATCH 3/4] t/annotate-tests.sh: avoid passing a non-newline terminated file to sed Brandon Casey
2009-05-06 18:29 ` [PATCH 4/4] t4200: " Brandon Casey
2009-05-06 18:48 ` Junio C Hamano
2009-05-06 21:12 ` Brandon Casey
2009-05-06 21:49 ` Junio C Hamano
2009-05-06 22:56 ` [PATCH 1/2] t4200: remove two unnecessary lines Brandon Casey
2009-05-06 22:56 ` [PATCH 2/2] t4200: convert sed expression which operates on non-text file to perl Brandon Casey
2009-05-06 23:24 ` Nguyen Thai Ngoc Duy
2009-05-07 1:49 ` [PATCH 4/4] t4200: avoid passing a non-newline terminated file to sed Nguyen Thai Ngoc Duy
2009-05-07 2:06 ` Brandon Casey
2009-05-07 2:29 ` Junio C Hamano
2009-05-07 7:26 ` Johannes Sixt
2009-05-07 14:57 ` Brandon Casey
2009-05-06 23:15 ` shell compatibility issues with SunOS 5.10 Nguyen Thai Ngoc Duy
2009-05-07 0:22 ` Brandon Casey
2009-05-07 1:14 ` Junio C Hamano
2009-05-07 2:23 ` Brandon Casey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=-ElxRhvpfY_jx1Ps8nJ42rHdrKbR03T1y96WpGK19gM@cipher.nrlssc.navy.mil \
--to=casey@nrlssc.navy.mil \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).