From: "Randall S. Becker" <rsbecker@nexbridge.com>
To: "'Jeff King'" <peff@peff.net>, "'Eric Wong'" <e@80x24.org>
Cc: "'Taylor Blau'" <me@ttaylorr.com>,
"'Junio C Hamano'" <gitster@pobox.com>, <git@vger.kernel.org>
Subject: RE: [ANNOUNCE] Git v2.32.0-rc3 - t5300 Still Broken on NonStop ia64/x86
Date: Wed, 2 Jun 2021 16:34:51 -0400 [thread overview]
Message-ID: <003c01d757ee$c0664600$4132d200$@nexbridge.com> (raw)
In-Reply-To: <YLfmo8kl0URnGgp5@coredump.intra.peff.net>
On June 2, 2021 4:14 PM, Peff wrote:
>Subject: Re: [ANNOUNCE] Git v2.32.0-rc3 - t5300 Still Broken on NonStop ia64/x86
>On Wed, Jun 02, 2021 at 08:11:50PM +0000, Eric Wong wrote:
>
>> Jeff King <peff@peff.net> wrote:
>> > And so when he gets this error:
>> >
>> > fatal: fsync error on '.git/objects/pack/tmp_pack_NkPgqN':
>> > Interrupted system call
>> >
>> > presumably we were in fsync() when the signal arrived, and unlike
>> > most other platforms, the call needs to be restarted manually (even
>> > though we set up the signal with SA_RESTART). I'm not sure if this
>> > violates POSIX or not (I couldn't find a definitive answer to the
>> > set of interruptible functions in the standard). But either way, the
>> > workaround is probably something like:
>>
>> "man 3posix fsync" says EINTR is allowed ("manpages-posix-dev"
>> package in Debian non-free).
>
>Ah, thanks. Linux's fsync(3) doesn't mention it, and nor does it appear in the discussion of interruptible calls in signals(7). So I was looking
>for a POSIX equivalent of that signals manpage but couldn't find one. :)
>
>> > #ifdef FSYNC_NEEDS_RESTART
>>
>> The wrapper should apply to all platforms. NFS (and presumably other
>> network FSes) can be mounted with interrupts enabled.
>
>I don't mind that, as the wrapper is pretty low-cost (and one less Makefile knob is nice). If it's widespread, though, I find it curious that
>nobody has run into it before now.
I suspect this is because of the way the file system on NonStop behaves. It is a multi-processor platform, with multi-cores, so anything can happen. If the file system is delayed for any reason, like a signal coming from a different core (EINTR has high priority), then fsync() will be interrupted. EINTR is allowed on NonStop for fsync(). So it would be really great if the patch included a modification to config.mak.uname to include that. This would be a timing-only issue on most other systems, probably something that would hit NFS.
The patch for the config is:
diff --git a/config.mak.uname b/config.mak.uname
index cb443b4e02..ac3e3ca2c5 100644
--- a/config.mak.uname
+++ b/config.mak.uname
@@ -566,6 +566,7 @@ ifeq ($(uname_S),NONSTOP_KERNEL)
NO_REGEX = NeedsStartEnd
NO_PTHREADS = UnfortunatelyYes
FREAD_READS_DIRECTORIES = UnfortunatelyYes
+ FSYNC_NEEDS_RESTART = YesPlease
# Not detected (nor checked for) by './configure'.
next prev parent reply other threads:[~2021-06-02 20:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 17:52 [ANNOUNCE] Git v2.32.0-rc3 - t5300 Still Broken on NonStop ia64/x86 Randall S. Becker
2021-06-02 19:32 ` Taylor Blau
2021-06-02 19:49 ` Jeff King
2021-06-02 20:11 ` Taylor Blau
2021-06-02 20:15 ` Jeff King
2021-06-02 20:36 ` Randall S. Becker
2021-06-04 1:36 ` Junio C Hamano
2021-06-04 2:17 ` Taylor Blau
2021-06-04 3:55 ` Jeff King
2021-06-04 5:12 ` Junio C Hamano
2021-06-06 19:06 ` Randall S. Becker
2021-06-08 6:40 ` Jeff King
2021-06-05 7:04 ` René Scharfe
2021-06-05 13:15 ` Junio C Hamano
2021-06-02 20:11 ` Eric Wong
2021-06-02 20:14 ` Jeff King
2021-06-02 20:18 ` Taylor Blau
2021-06-02 20:34 ` Randall S. Becker [this message]
2021-06-03 19:31 ` Jeff King
2021-06-03 20:07 ` Randall S. Becker
2021-06-03 20:21 ` Bryan Turner
2021-06-03 20:32 ` Randall S. Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='003c01d757ee$c0664600$4132d200$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).