git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Randall S. Becker" <rsbecker@nexbridge.com>
To: "'Pratyush Yadav'" <me@yadavpratyush.com>
Cc: <git@vger.kernel.org>
Subject: RE: [BUG] Installing git-gui (2.27.0)
Date: Tue, 23 Jun 2020 09:21:02 -0400	[thread overview]
Message-ID: <009701d64961$27667610$76336230$@nexbridge.com> (raw)
In-Reply-To: <20200623124726.3f3g7gmm7zfwxvhu@yadavpratyush.com>

On, June 23, 2020 8:47 AM, Pratyush Yadav:
> On 08/06/20 10:02AM, Randall S. Becker wrote:
> > Hi,
> >
> > This is what I found when trying to install the whole git package on
> > the NonStop TNS/E platform:
> >
> >  DEST /usr/local/share/git-gui/lib
> >     INSTALL 644 tclIndex
> > install: cannot stat 'lib/tclIndex': No such file or directory
> > Makefile:293: recipe for target 'install' failed
> >
> > I’m not sure why we are only hitting this now at 2.27.0. We don’t use
> > git-gui anyway on this platform as it has no GUI interface. It looks
> > like the install script runs auto_mkindex that actually does nothing
> > in our case, so lib/tclIndex is not built.
> >
> > This does block the install from completing successfully. To bypass, I
> > added the following:
> >
> > index f10caedaa7..943febaf75 100644
> > --- a/git-gui/Makefile
> > +++ b/git-gui/Makefile
> > @@ -256,6 +256,7 @@ lib/tclIndex: $(ALL_LIBFILES) GIT-GUI-VARS
> >           $(foreach p,$(PRELOAD_FILES),source $p\;) \
> >           auto_mkindex lib $(patsubst lib/%,%,$(sort $(ALL_LIBFILES))) \
> >         | $(TCL_PATH) $(QUIET_2DEVNULL); then : ok; \
> > +        echo >>$@ ; \
> >         else \
> >          echo >&2 "    * $(TCL_PATH) failed; using unoptimized loading";
\
> >          rm -f $@ ; \
> >
> 
> IIUC, this is a NonStop-specific problem. This fix shouldn't go in the
git-gui
> 'master', right?

The component is still part of the git build, so unless it can be severed by
configuration, it should go into 'master'. The Makefile should still
generate a tclIndex, which the foreach is not guaranteed to do, apparently.

Randall



      reply	other threads:[~2020-06-23 13:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-08 14:02 [BUG] Installing git-gui (2.27.0) Randall S. Becker
2020-06-23 12:47 ` Pratyush Yadav
2020-06-23 13:21   ` Randall S. Becker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='009701d64961$27667610$76336230$@nexbridge.com' \
    --to=rsbecker@nexbridge.com \
    --cc=git@vger.kernel.org \
    --cc=me@yadavpratyush.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).